Skip to content

Conversation

@dakersnar
Copy link
Contributor

Fixes dotnet/runtime#72410, specifically the ones called out in this comment dotnet/runtime#72410 (comment).

I tried to be as consistent as possible, and I also fixed other small issues I came across during the process. Let me know if anything needs to be tweaked, or if I missed anything.

@dakersnar dakersnar requested a review from a team as a code owner September 19, 2022 19:57
@ghost ghost assigned dakersnar Sep 19, 2022
@ghost
Copy link

ghost commented Sep 19, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@dakersnar dakersnar changed the title Fix runtime 72410 Update System.Numerics Docs Sep 19, 2022
@opbld31

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

@opbld30

This comment was marked as outdated.

@opbld30
Copy link

opbld30 commented Sep 20, 2022

Docs Build status updates of commit f70f6e0:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System/Decimal.xml 💡Suggestion View Details
xml/System/Double.xml 💡Suggestion View Details
xml/System/Half.xml 💡Suggestion View Details
xml/System/Int128.xml 💡Suggestion View Details
xml/System/Single.xml 💡Suggestion View Details
xml/System/UInt128.xml 💡Suggestion View Details
xml/System/Byte.xml ✅Succeeded View
xml/System/Enum.xml ✅Succeeded View
xml/System/Int16.xml ✅Succeeded View
xml/System/Int32.xml ✅Succeeded View
xml/System/Int64.xml ✅Succeeded View
xml/System/IntPtr.xml ✅Succeeded View
xml/System/SByte.xml ✅Succeeded View
xml/System/Type.xml ✅Succeeded View
xml/System/UInt16.xml ✅Succeeded View
xml/System/UInt32.xml ✅Succeeded View
xml/System/UInt64.xml ✅Succeeded View
xml/System/UIntPtr.xml ✅Succeeded View

xml/System/Decimal.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Decrement(System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Division(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Equality(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_GreaterThan(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_GreaterThanOrEqual(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Increment(System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Inequality(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_LessThan(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_LessThanOrEqual(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Modulus(System.Decimal,System.Decimal).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Decimal.op_Multiply(System.Decimal,System.Decimal).

xml/System/Double.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_Equality(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_GreaterThan(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_GreaterThanOrEqual(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_Inequality(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_LessThan(System.Double,System.Double).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Double.op_LessThanOrEqual(System.Double,System.Double).

xml/System/Half.xml

  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Addition(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Decrement(System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Division(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Equality(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_GreaterThan(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_GreaterThanOrEqual(System.Half,System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Increment(System.Half).
  • Line 0, Column 0: [Suggestion: ECMA2Yaml_Inheritdoc_NotSupportType] Inheridoc not support type: Operator for uid:System.Half.op_Inequality(System.Half,System.Half).

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@gewarren gewarren merged commit 8dfd6d3 into dotnet:main Sep 20, 2022
@gewarren gewarren mentioned this pull request Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Undocumented 7.0 APIs in System.Numerics

5 participants