Skip to content

Conversation

@wenz
Copy link
Contributor

@wenz wenz commented Oct 27, 2022

Summary

Document NewLineChars default values on different operating systems.

Fixes #8315

@wenz wenz requested a review from a team as a code owner October 27, 2022 08:04
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Xml labels Oct 27, 2022
@ghost
Copy link

ghost commented Oct 27, 2022

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

Document NewLineChars default values on different operating systems.

Fixes #8315

Author: wenz
Assignees: -
Labels:

area-System.Xml, community-contribution

Milestone: -

@opbld32
Copy link

opbld32 commented Oct 27, 2022

Learn Build status updates of commit 1b4c34d:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Xml/XmlWriter.xml ✅Succeeded View
xml/System.Xml/XmlWriterSettings.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Oct 28, 2022

Learn Build status updates of commit ff12718:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Xml/XmlWriter.xml ✅Succeeded View
xml/System.Xml/XmlWriterSettings.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although consider mentioning this is correlated with https://learn.microsoft.com/en-us/dotnet/api/system.environment.newline?view=net-7.0

@krwq krwq merged commit d379d54 into dotnet:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Xml community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XmlWriterSettings.NewLineChars defaults to "\n" on Linux, contrary to docs

5 participants