Skip to content

Remove incomplete sentence #8589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gewarren merged 1 commit into from
Oct 28, 2022
Merged

Remove incomplete sentence #8589

gewarren merged 1 commit into from
Oct 28, 2022

Conversation

@wenz
Copy link
Contributor

@wenz wenz commented Oct 27, 2022

Summary

Remove incomplete sentence

Fixes #8196

@wenz wenz requested a review from a team as a code owner October 27, 2022 08:22
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-WPF Issues or PRs that relate to WPF or XAML. labels Oct 27, 2022
@opbld30
Copy link

opbld30 commented Oct 27, 2022

Learn Build status updates of commit a113fd3:

✅ Validation status: passed

File Status Preview URL Details
xml/System.IO/File.xml ✅Succeeded View
xml/System.Windows.Input/KeyGesture.xml ✅Succeeded View
xml/System.Xml/XmlWriter.xml ✅Succeeded View
xml/System.Xml/XmlWriterSettings.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren
Copy link
Contributor

gewarren commented Oct 27, 2022

@wenz It looks like this PR includes some files that you changed for other PRs, e.g. #8588. Can you remove those files from this PR?

@wenz
Copy link
Contributor Author

wenz commented Oct 28, 2022

@wenz It looks like this PR includes some files that you changed for other PRs, e.g. #8588. Can you remove those files from this PR?

Fixed - sorry again, and thanks!

@opbld34
Copy link

opbld34 commented Oct 28, 2022

Learn Build status updates of commit 7dc68ba:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Windows.Input/KeyGesture.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

gewarren
gewarren approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wenz

@gewarren gewarren merged commit 0aae9b7 into dotnet:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

Assignees

No one assigned

Labels

area-WPF Issues or PRs that relate to WPF or XAML. community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remarks section for KeyGesture missing text

4 participants

@wenz @opbld30 @gewarren @opbld34