Skip to content

Conversation

@huangmin-ms
Copy link
Contributor

@huangmin-ms huangmin-ms commented Nov 17, 2022

@huangmin-ms huangmin-ms requested a review from a team as a code owner November 17, 2022 03:44
@ghost ghost assigned huangmin-ms Nov 17, 2022
@ghost
Copy link

ghost commented Nov 17, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@huangmin-ms huangmin-ms changed the title Workaround for https://dev.azure.com/ceapex/Engineering/_workitems/ed… Use   as white space to workaround mdoc overwriting issue Nov 17, 2022
@huangmin-ms huangmin-ms changed the title Use   as white space to workaround mdoc overwriting issue Use   as white space Nov 17, 2022
@huangmin-ms huangmin-ms changed the title Use   as white space Use   as white space in xml Nov 17, 2022
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather just reword as suggested if the whitespace issue isn't going to be fixed. Otherwise someone might come in later and replace   with a space character, not knowing the history.

@opbld32
Copy link

opbld32 commented Nov 17, 2022

Learn Build status updates of commit eb4b8f1:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/CommandLineConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsSnapshot`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsManager`1.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/UnscopedRefAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren reopened this Nov 17, 2022
@gewarren gewarren enabled auto-merge (squash) November 17, 2022 20:09
@gewarren gewarren added the area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable. label Nov 17, 2022
@opbld31
Copy link

opbld31 commented Nov 17, 2022

Learn Build status updates of commit eb4b8f1:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/CommandLineConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsSnapshot`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsManager`1.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/UnscopedRefAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld34
Copy link

opbld34 commented Nov 17, 2022

Learn Build status updates of commit 4bbb824:

✅ Validation status: passed

File Status Preview URL Details
xml/Microsoft.Extensions.Configuration/CommandLineConfigurationExtensions.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsMonitor`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/IOptionsSnapshot`1.xml ✅Succeeded View
xml/Microsoft.Extensions.Options/OptionsManager`1.xml ✅Succeeded View
xml/System.Diagnostics.CodeAnalysis/UnscopedRefAttribute.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@gewarren gewarren merged commit 2034b96 into main Nov 17, 2022
@gewarren gewarren deleted the mh/white-space-workaround branch November 17, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-Meta Concerns something that extends across runtime area boundaries, for example, IDisposable.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants