Skip to content

Conversation

@MageFroh
Copy link

Summary

As far as I understand the DangerousAcceptAnyServerCertificateValidator mechanism (thanks to the little code snippet), the framework checks whether ServerCertificateCustomValidationCallback is set to that value. It does not make sense to check the value of DangerousAcceptAnyServerCertificateValidator, since it's a read-only property anyway.

As far as I understand the `DangerousAcceptAnyServerCertificateValidator` mechanism (thanks to the little code snippet), the framework checks whether `ServerCertificateCustomValidationCallback` is set to that value.
It does not make sense to check the value of `DangerousAcceptAnyServerCertificateValidator`, since it's a read-only property anyway.
@MageFroh MageFroh requested a review from a team as a code owner November 29, 2022 22:02
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Net.Http labels Nov 29, 2022
@ghost
Copy link

ghost commented Nov 29, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Summary

As far as I understand the DangerousAcceptAnyServerCertificateValidator mechanism (thanks to the little code snippet), the framework checks whether ServerCertificateCustomValidationCallback is set to that value. It does not make sense to check the value of DangerousAcceptAnyServerCertificateValidator, since it's a read-only property anyway.

Author: MageFroh
Assignees: -
Labels:

area-System.Net.Http, community-contribution

Milestone: -

@opbld30
Copy link

opbld30 commented Nov 29, 2022

Learn Build status updates of commit 53ad8da:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Http/HttpClientHandler.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 97c6865 into dotnet:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Net.Http community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants