-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add link to QUIC prerequisities and supported operating systems #8750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes dotnet/runtime#80001
|
|
Learn Build status updates of commit 135272d: 💡 Validation status: suggestions
xml/System.Net.Quic/QuicConnection.xml
xml/System.Net.Quic/QuicListener.xml
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. For any questions, please:
|
Co-authored-by: Genevieve Warren <[email protected]>
wfurt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We should perhaps also improve the linked page but that can be separate change.
Windows should mention Server 2022 IMHO.
Linux calls for OpenSSL 1.1 and that seems incomplete. There is 1.1.0 and 1.1.1. First one will not work (and is out of support) We should probably explicitly mention that OpenSSL 3 is NOT supported e.g. we will have problems on (.NET supported) Ubuntu 22
Perhaps link to MsQuic support page.
Also Pointing Quic to HTTP3 seems like reverse order since Http3 depends on Quic not vice versa.
|
Learn Build status updates of commit b8023f0: ✅ Validation status: passed
For more details, please refer to the build report. Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report. For any questions, please:
|
I will update the other PR with this info.
Do you mean https://github.com/microsoft/msquic/blob/main/docs/Platforms.md ? It does not have any of these details about OpenSSL.
I agree. Unfortunately, we have linked to the HTTP3 doc for QUIC platform support from number of places already (blog posts, issues, etc.). |
|
Eventually, there should be conceptual docs for System.Net.Quic. We should then shuffle it and put the prereqs, dependecies, msquic docs links etc. there instead. |
ManickaP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes dotnet/runtime#80001