Skip to content

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Dec 29, 2022

@jkotas jkotas requested a review from a team as a code owner December 29, 2022 22:14
@ghost ghost assigned jkotas Dec 29, 2022
@ghost ghost added the area-System.Net label Dec 29, 2022
@ghost
Copy link

ghost commented Dec 29, 2022

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes dotnet/runtime#80001

Author: jkotas
Assignees: jkotas
Labels:

area-System.Net

Milestone: -

@jkotas jkotas requested review from ManickaP and wfurt December 29, 2022 22:15
@learn-build-service-prod
Copy link

Learn Build status updates of commit 135272d:

💡 Validation status: suggestions

File Status Preview URL Details
xml/System.Net.Quic/QuicConnection.xml 💡Suggestion View Details
xml/System.Net.Quic/QuicListener.xml 💡Suggestion View Details

xml/System.Net.Quic/QuicConnection.xml

  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

xml/System.Net.Quic/QuicListener.xml

  • Line 0, Column 0: [Suggestion: disallowed-html-tag - See documentation] HTML tag 'see' isn't allowed. Replace it with approved Markdown or escape the brackets if the content is a placeholder.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Co-authored-by: Genevieve Warren <[email protected]>
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We should perhaps also improve the linked page but that can be separate change.

Windows should mention Server 2022 IMHO.
Linux calls for OpenSSL 1.1 and that seems incomplete. There is 1.1.0 and 1.1.1. First one will not work (and is out of support) We should probably explicitly mention that OpenSSL 3 is NOT supported e.g. we will have problems on (.NET supported) Ubuntu 22
Perhaps link to MsQuic support page.

Also Pointing Quic to HTTP3 seems like reverse order since Http3 depends on Quic not vice versa.

@learn-build-service-prod
Copy link

Learn Build status updates of commit b8023f0:

✅ Validation status: passed

File Status Preview URL Details
xml/System.Net.Quic/QuicConnection.xml ✅Succeeded View
xml/System.Net.Quic/QuicListener.xml ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@jkotas
Copy link
Member Author

jkotas commented Dec 30, 2022

Windows should mention Server 2022 IMHO.

I will update the other PR with this info.

There is 1.1.0 and 1.1.1. First one will not work (and is out of support) We should probably explicitly mention that OpenSSL 3 is NOT supported
Perhaps link to MsQuic support page.

Do you mean https://github.com/microsoft/msquic/blob/main/docs/Platforms.md ? It does not have any of these details about OpenSSL.

Also Pointing Quic to HTTP3 seems like reverse order since Http3 depends on Quic not vice versa.

I agree. Unfortunately, we have linked to the HTTP3 doc for QUIC platform support from number of places already (blog posts, issues, etc.).

@ManickaP
Copy link
Member

ManickaP commented Jan 2, 2023

Eventually, there should be conceptual docs for System.Net.Quic. We should then shuffle it and put the prereqs, dependecies, msquic docs links etc. there instead.
I would keep it as it is now, and fix this all with S.N.Quic conceptual docs for which I created an issue: dotnet/docs#33287

Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas jkotas merged commit 1e0f2ca into dotnet:main Jan 2, 2023
@jkotas jkotas deleted the quic-support branch January 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document System.Net.Quic prerequisites and supported OSes

4 participants