Add dockerfile for fedora 33#398
Conversation
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Co-authored-by: Matt Thalman <mthalman@microsoft.com>
dougbu
left a comment
dougbu
left a comment
There was a problem hiding this comment.
I'm not a docker expert but…
| } | ||
| } | ||
| }] | ||
| }, |
There was a problem hiding this comment.
I am probably missing something. But, why do we need a non-Helix queue for Fedora/33❔
There was a problem hiding this comment.
I am probably missing something. But, why do we need a non-Helix queue for Fedora/33❔
It's not a queue, it's a base image; while I don't fully know who the user was for fedora 32, this pattern was there and allows building other .NET Core ready images off Fedora 32 and reduces the amount of stuff Helix images install to primarily helix-specific images.
| @@ -0,0 +1,43 @@ | |||
| FROM fedora:33 | |||
There was a problem hiding this comment.
Does the CI verify fedora:33 is a good enough base for this queue❔ If, for example, you copied this docker file from one for Fedora 32, are the two versions different in some way that might be a concern❔
There was a problem hiding this comment.
yes; if all the commands executed don't succeed, this CI will fail. I also built both images locally and checked them out before signing off.
There was a problem hiding this comment.
Cool, so after you guys merge this PR, how will I know the exact docker string for the helix queue to try in our builds?
There was a problem hiding this comment.
It will get automatically recorded in https://github.com/dotnet/versions/blob/master/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-master.json
4 participants
Per @MattGal try to add a new docker image for fedora 33 for asp.net's helix matrix
cc @dotnet/aspnet-build @Pilchie