Add new docker image with node built from source in order to be able to use it in azure dev ops #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to use it in azure dev ops
Member
MichaelSimons
left a comment
MichaelSimons
left a comment
There was a problem hiding this comment.
I just have a few styling comments.
Member
Author
|
test fedora please |
Member
Author
|
@MichaelSimons looks good now? |
Member
Author
|
@MichaelSimons sorry for the delay, I fixed the identation. |
Member
Author
|
@dotnet-bot test centos_6 please |
MichaelSimons
approved these changes
Dec 4, 2018
Member
|
The following images were produced as a result of merging this PR: microsoft/dotnet-buildtools-prereqs:alpine-3.6-dc92048-20181204212646 |
Member
Author
|
Thanks @MichaelSimons for the review and follow up 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use non glibc docker images in azure devops we need to build node from source in this type of images since they rely on node to execute their pipelines.
cc: @danmosemsft @chcosta @markwilkie