Remove gcc 12 from ubuntu image #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was added in #843 so that we could use it in runtime's gcc builds, but #850 lets us continue using the existing official debian-based image, so this is no longer necessary.
In fact, the presence of the gcc 12 toolchain directory was causing unrelated problems in dotnet/runtime#84795, because we didn't have
libstdc++-12-devinstalled, but clang was selecting the gcc 12 toolchain. Removing it will let that build use the libstdc++ 11 that is already installed as a dependency of clang-14.@am11 @jkoritzinsky PTAL (@am11 I can't add you directly as a reviewer or I would)