Bump Cosmos SDK to 3.46.0 #35171
Merged
Bump Cosmos SDK to 3.46.0 #35171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Nov 21, 2024
Member
Author
|
Cosmos SDK now wants its users to reference Newtonsoft.JSON themselves (issue). Following the same logic, I think our provider shouldn't reference it, but our tests will need to (hopefully that's going to work). |
Member
Author
|
OK, looks like we have to reference Newtonsoft.JSON anyway, since we use Newtonsoft in our own code (in the provider itself). If we one day stop doing that, we'd have the question of whether we should reference Newtonsoft.JSON at all here, or set AzureCosmosDisableNewtonsoftJsonCheck to true (but at that point, I'm not sure if applications using our provider get the build error telling them to reference Newtonsoft.JSON). |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new SDK is notably needed to use the new Linux-based Cosmos emulator.