-
Notifications
You must be signed in to change notification settings - Fork 850
Cache current process object to avoid performance hit #5597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evgenyfedorov2
merged 4 commits into
dotnet:main
from
haipz:cachecurrentprocessinprocessinfo
Nov 12, 2024
+26
−4
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
c3f6631
Read working set from Environment in ProcessInfo since it has better …
haipz f7a9d62
Add unit test for ProcessInfo.
haipz 83672ac
Remove OSSkipCondition tag from process info unit test since it's cro…
haipz 23f0de9
Use Environment.WorkingSet in GetMemoryUsageInBytes.
haipz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...ies/Microsoft.Extensions.Diagnostics.ResourceMonitoring.Tests/Windows/ProcessInfoTests.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| // Licensed to the .NET Foundation under one or more agreements. | ||
| // The .NET Foundation licenses this file to you under the MIT license. | ||
|
|
||
| using Microsoft.Extensions.Diagnostics.ResourceMonitoring.Windows.Interop; | ||
| using Microsoft.TestUtilities; | ||
| using Xunit; | ||
|
|
||
| namespace Microsoft.Extensions.Diagnostics.ResourceMonitoring.Windows.Test; | ||
|
|
||
| /// <summary> | ||
| /// Process Info Interop Tests. | ||
| /// </summary> | ||
| /// <remarks>These tests are added for coverage reasons, but the code doesn't have | ||
| /// the necessary environment predictability to really test it.</remarks> | ||
| public sealed class ProcessInfoTests | ||
| { | ||
| [ConditionalFact] | ||
| public void GetCurrentProcessMemoryUsage() | ||
| { | ||
| var workingSet64 = new ProcessInfo().GetCurrentProcessMemoryUsage(); | ||
| Assert.True(workingSet64 > 0); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.