Skip to content

Annotate private DebuggerDisplay props as DebuggerBrowsableState.Never #5656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephentoub merged 1 commit into from
Nov 18, 2024
Merged

Annotate private DebuggerDisplay props as DebuggerBrowsableState.Never #5656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseFormatJson.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,6 @@ public override int GetHashCode() =>
typeof(ChatResponseFormatJson).GetHashCode();

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private string DebuggerDisplay => Schema ?? "JSON";
}
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/RequiredChatToolMode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ public RequiredChatToolMode(string? requiredFunctionName)
// Equals/GetHashCode as well, which they likely won't.

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private string DebuggerDisplay => $"Required: {RequiredFunctionName ?? "Any"}";

/// <inheritdoc/>
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/Contents/DataContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,7 @@ public ReadOnlyMemory<byte>? Data
}

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private string DebuggerDisplay
{
get
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/Contents/FunctionCallContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ public static FunctionCallContent CreateFromParsedArguments<TEncoding>(
}

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private string DebuggerDisplay
{
get
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/Contents/FunctionResultContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public FunctionResultContent(string callId, string name, object? result)
public Exception? Exception { get; set; }

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private string DebuggerDisplay
{
get
Expand Down
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/Contents/UsageContent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,6 @@ public UsageDetails Details
}

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
private string DebuggerDisplay => _details.DebuggerDisplay;
}
1 change: 1 addition & 0 deletions src/Libraries/Microsoft.Extensions.AI.Abstractions/UsageDetails.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ public class UsageDetails
public AdditionalPropertiesDictionary? AdditionalProperties { get; set; }

/// <summary>Gets a string representing this instance to display in the debugger.</summary>
[DebuggerBrowsable(DebuggerBrowsableState.Never)]
internal string DebuggerDisplay
{
get
Expand Down
Loading