Skip to content

Conversation

@stephentoub
Copy link
Member

@stephentoub stephentoub commented Sep 3, 2025

@stephentoub stephentoub requested a review from a team as a code owner September 3, 2025 02:17
@github-actions github-actions bot added the area-ai Microsoft.Extensions.AI libraries label Sep 3, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the OpenTelemetry instrumentation in Microsoft.Extensions.AI to conform to the latest 1.37.0 draft specification of the Semantic Conventions for Generative AI systems. The changes include updating tag names and replacing logging-based telemetry with activity tags for better structured data.

  • Updated OpenTelemetry semantic conventions from v1.36 to v1.37
  • Replaced logging-based telemetry with structured activity tags for messages
  • Standardized provider-specific tag naming conventions

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
OpenTelemetryConsts.cs Updated constant definitions to align with v1.37 conventions, added new message-related constants
OpenTelemetryChatClient.cs Replaced logging with activity tags for message serialization and updated tag names
OpenTelemetryEmbeddingGenerator.cs Updated tag names and variable naming to match new conventions
FunctionInvokingChatClient.cs Updated to use constants for operation name and tool type
Test files Updated test assertions to match new tag naming conventions
CHANGELOG.md Added entry documenting the OpenTelemetry update

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@stephentoub stephentoub merged commit 20349f8 into dotnet:main Sep 3, 2025
7 checks passed
@stephentoub stephentoub deleted the genai137 branch September 3, 2025 11:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ai Microsoft.Extensions.AI libraries

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants