Skip to content

update metadata resolver usage, fix tests

040e51b
Select commit
Loading
Failed to load commit list.
Merged

HttpDependencyMetadataResolver class for the custom downstream dependency metadata resolution #6880

update metadata resolver usage, fix tests
040e51b
Select commit
Loading
Failed to load commit list.
Azure Pipelines / extensions-ci (Correctness WarningsCheck) failed Oct 6, 2025 in 9m 2s

Correctness WarningsCheck failed

Annotations

Check failure on line 46 in src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs#L46

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs(46,13): error LA0001: (NETCORE_ENGINEERING_TELEMETRY=Build) Use 'Microsoft.Shared.Diagnostics.Throws.ArgumentNullException' to throw the exception instead to improve performance

Check failure on line 91 in src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs#L91

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs(91,48): error CA1062: (NETCORE_ENGINEERING_TELEMETRY=Build) In externally visible method 'RequestMetadata? HttpDependencyMetadataResolver.GetRequestMetadata(HttpWebRequest requestMessage)', validate parameter 'requestMessage' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)

Check failure on line 70 in src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs#L70

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDiagnosticsServiceCollectionExtensions.cs(70,34): error CA1062: (NETCORE_ENGINEERING_TELEMETRY=Build) In externally visible method 'IServiceCollection HttpDiagnosticsServiceCollectionExtensions.AddHttpDependencyMetadataResolver(IServiceCollection services, params IDownstreamDependencyMetadata[] providers)', validate parameter 'providers' is non-null before using it. If appropriate, throw an 'ArgumentNullException' when the argument is 'null'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1062)

Check failure on line 12 in src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/DefaultHttpDependencyMetadataResolver.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/DefaultHttpDependencyMetadataResolver.cs#L12

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/DefaultHttpDependencyMetadataResolver.cs(12,21): error LA0003: (NETCORE_ENGINEERING_TELEMETRY=Build) Newly added symbol 'Microsoft.Extensions.Http.Diagnostics.DefaultHttpDependencyMetadataResolver' must be marked as experimental

Check failure on line 22 in src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs

See this annotation in the file changed.

@azure-pipelines azure-pipelines / extensions-ci (Correctness WarningsCheck)

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs#L22

src/Libraries/Microsoft.Extensions.Http.Diagnostics/Http/HttpDependencyMetadataResolver.cs(22,23): error LA0003: (NETCORE_ENGINEERING_TELEMETRY=Build) Newly added symbol 'Microsoft.Extensions.Http.Diagnostics.HttpDependencyMetadataResolver' must be marked as experimental