-
Notifications
You must be signed in to change notification settings - Fork 849
Update AI Chat Web template to Aspire 13.0.0 #7036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0587d66 to
b240b82
Compare
|
Getting this failure in the template execution tests: Detected package downgrade: Microsoft.Extensions.AI from 10.0.0 to 10.0.0-ci. Reference the package directly from the project to select a different version.This is happening because @jeffhandley is it OK to make branding changes in this PR (incrementing the minor version)? That would solve this issue, but I know that we usually the change minor version in dedicated "branding update" PRs. |
|
@MackinnonBuck This should be unblocked now with Merge rel10 (#7047) having been merged in. |
|
@MackinnonBuck I just realized this would also be blocked by (#7018) Bump version to 10.1.0 for next development cycle, and that is still open/draft. |
Co-authored-by: MackinnonBuck <[email protected]>
Co-authored-by: MackinnonBuck <[email protected]>
b240b82 to
f470b7a
Compare
|
@MackinnonBuck I rebased to pull those changes in. I think it's otherwise good to go, but I'll run some end-to-end validation tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the AI Chat Web template to use Aspire 13.0.0, which was recently published. The changes update package references from version 9.5.1 to 13.0.0 for all Aspire packages, and update Microsoft.Extensions.ServiceDiscovery from 9.5.1 to 10.0.0 (as version 13.0.0 doesn't exist for this package).
- Updated Aspire package versions in GeneratedContent.targets from 9.5.1 to 13.0.0
- Updated ServiceDiscovery package to version 10.0.0 (latest available)
- Regenerated template snapshots for 3 Aspire variants (BasicAspire, AzureOpenAI_Qdrant_Aspire, Ollama_Qdrant)
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ProjectTemplates/GeneratedContent.targets | Updated Aspire and ServiceDiscovery version properties that drive template generation |
| test/.../aichatweb.BasicAspire.verified/aichatweb/aichatweb.AppHost/aichatweb.AppHost.csproj | Updated AppHost SDK and package references to Aspire 13.0.0 |
| test/.../aichatweb.BasicAspire.verified/aichatweb/aichatweb.ServiceDefaults/aichatweb.ServiceDefaults.csproj | Updated ServiceDiscovery package to 10.0.0 |
| test/.../aichatweb.BasicAspire.verified/aichatweb/aichatweb.Web/aichatweb.Web.csproj | Updated Aspire.Azure.AI.OpenAI preview package to 13.0.0-preview.1.25560.3 |
| test/.../aichatweb.AzureOpenAI_Qdrant_Aspire.verified/aichatweb/aichatweb.AppHost/aichatweb.AppHost.csproj | Updated AppHost SDK and hosting packages to Aspire 13.0.0 |
| test/.../aichatweb.AzureOpenAI_Qdrant_Aspire.verified/aichatweb/aichatweb.ServiceDefaults/aichatweb.ServiceDefaults.csproj | Updated ServiceDiscovery package to 10.0.0 |
| test/.../aichatweb.AzureOpenAI_Qdrant_Aspire.verified/aichatweb/aichatweb.Web/aichatweb.Web.csproj | Updated Aspire Azure packages to 13.0.0 |
| test/.../aichatweb.Ollama_Qdrant.verified/aichatweb/aichatweb.AppHost/aichatweb.AppHost.csproj | Updated AppHost SDK and Qdrant hosting package to Aspire 13.0.0 |
| test/.../aichatweb.Ollama_Qdrant.verified/aichatweb/aichatweb.ServiceDefaults/aichatweb.ServiceDefaults.csproj | Updated ServiceDiscovery package to 10.0.0 |
| test/.../aichatweb.Ollama_Qdrant.verified/aichatweb/aichatweb.Web/aichatweb.Web.csproj | Updated Aspire.Qdrant.Client package to 13.0.0 |
jeffhandley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test Pass Results
Total: 17 tests (all Aspire scenarios)
✅ Passed: 13 (76%)
❌ Failed: 0 (0%)
⏭️ Skipped: 0 (0%)
Result Details
- All non-Ollama providers (Azure OpenAI, GitHub Models, OpenAI) passed completely
- All Ollama tests had the known issue with citations not being rendered properly
- All tests successfully logged searches and included appropriate emergency kit content
- Both managed identity and standard authentication modes work correctly across all providers
|
Thanks for rebasing and running the validation, @jeffhandley!! |
* Initial plan * Update Aspire version to 13.0.0 in GeneratedContent.targets Co-authored-by: MackinnonBuck <[email protected]> * Update template snapshots with Aspire 13.0.0 and ServiceDiscovery 10.0.0 Co-authored-by: MackinnonBuck <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: MackinnonBuck <[email protected]>
* Initial plan * Update Aspire version to 13.0.0 in GeneratedContent.targets Co-authored-by: MackinnonBuck <[email protected]> * Update template snapshots with Aspire 13.0.0 and ServiceDiscovery 10.0.0 Co-authored-by: MackinnonBuck <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: MackinnonBuck <[email protected]>
Aspire 13.0.0 was recently published. This updates the AI Chat Web template to reference the new version.
Changes
All snapshot tests pass with the updated versions.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/dotnet/aspire/releasescurl -s REDACTED(http block)https://api.github.com/repos/dotnet/aspire/tagscurl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow