.NET: Change type of ContinuationToken properties #7050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Nov 17, 2025
test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIResponseClientIntegrationTests.cs
Show resolved
Hide resolved
15 tasks
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves type safety by changing the ContinuationToken property type from object? to ResponseContinuationToken? across three key chat completion classes: ChatOptions, ChatResponse, and ChatResponseUpdate. This change provides stronger type checking at compile time while maintaining the same runtime behavior.
Key Changes
- Updated
ContinuationTokenproperty type fromobject?toResponseContinuationToken?inChatOptions,ChatResponse, andChatResponseUpdate - Updated test code to use the new strongly-typed
ResponseContinuationToken?instead ofobject?
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatOptions.cs | Changed ContinuationToken property type to ResponseContinuationToken? |
| src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponse.cs | Changed ContinuationToken property type to ResponseContinuationToken? |
| src/Libraries/Microsoft.Extensions.AI.Abstractions/ChatCompletion/ChatResponseUpdate.cs | Changed ContinuationToken property type to ResponseContinuationToken? |
| test/Libraries/Microsoft.Extensions.AI.OpenAI.Tests/OpenAIResponseClientIntegrationTests.cs | Updated test variable declaration to use ResponseContinuationToken? |
…ontinuationToken?
stephentoub
force-pushed
the
change-type-of-continuation-token
branch
from
e9f5920 to
265f919
Compare
stephentoub
approved these changes
Nov 21, 2025
stephentoub
force-pushed
the
change-type-of-continuation-token
branch
from
265f919 to
b1480b9
Compare
stephentoub
added a commit
to jeffhandley/extensions
that referenced
this pull request
Nov 21, 2025
* Change type of ContinuationToken properties from object? to ResponseContinuationToken? * Delete unnecessary compat suppressions --------- Co-authored-by: Stephen Toub <[email protected]>
jeffhandley
pushed a commit
that referenced
this pull request
Nov 21, 2025
* Change type of ContinuationToken properties from object? to ResponseContinuationToken? * Delete unnecessary compat suppressions --------- Co-authored-by: Stephen Toub <[email protected]>
Member
|
|
jeffhandley
added
the
breaking-change
This was referenced Dec 11, 2025
This was referenced Dec 17, 2025
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the type of the
ChatOptions.ContinuationToken,ChatResponse.ContinuationToken, andChatResponseUpdate.ContinuationTokenproperties fromobject?toResponseContinuationToken?.CC: @stephentoub