Skip to content

Expose wrapHandlersPipeline parameter in AddExtendedHttpClientLogging API #7231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rainsxng merged 11 commits into from
Feb 10, 2026
Merged

Expose wrapHandlersPipeline parameter in AddExtendedHttpClientLogging API #7231

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
19a2a6c
new api surface, first test iteration
rainsxng Jan 26, 2026
930c40d
fix tests
rainsxng Jan 26, 2026
3da8f98
add experimental attributes
rainsxng Jan 26, 2026
4373f93
Merge branch 'main' into dbohdanov/diagnostics-latecy-api-update
rainsxng Jan 27, 2026
4018e1a
Update test/Libraries/Microsoft.Extensions.Http.Diagnostics.Tests/Lat…
rainsxng Jan 27, 2026
e3134ec
Merge branch 'main' into dbohdanov/diagnostics-latecy-api-update
rainsxng Feb 3, 2026
e669fef
move and remove tests
rainsxng Feb 4, 2026
25674fb
fix warnings
rainsxng Feb 4, 2026
3ed422b
update xml documentation
rainsxng Feb 9, 2026
3cbef28
additional tests coverage
rainsxng Feb 9, 2026
6818b8d
update tests and xml documentation
rainsxng Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move and remove tests
  • Loading branch information
@rainsxng
rainsxng committed Feb 4, 2026
commit e669fef6dc4dfbac3caa6bb991a5248c7df480bf
128 changes: 0 additions & 128 deletions ...oft.Extensions.Http.Diagnostics.Tests/Latency/HttpClientLatencyTelemetryExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,124 +109,6 @@ public void RequestLatencyExtensions_Add_BindsToConfigSection()
Assert.Equal(expectedOptions.EnableDetailedLatencyBreakdown, options.EnableDetailedLatencyBreakdown);
}

[Fact]
public async Task LatencyInfo_IsPopulated_WhenLoggerWrapsHandlersPipeline()
{
using var sp = new ServiceCollection()
.AddLatencyContext()
.AddRedaction()
.AddHttpClientLatencyTelemetry()
.AddHttpClient("test")
.ConfigurePrimaryHttpMessageHandler(() => new ServerNameStubHandler("TestServer"))
.AddExtendedHttpClientLogging(wrapHandlersPipeline: true)
.Services
.AddFakeLogging()
.BuildServiceProvider();

var client = sp.GetRequiredService<IHttpClientFactory>().CreateClient("test");

using var response = await client.GetAsync("http://localhost/api");
Assert.Equal(HttpStatusCode.OK, response.StatusCode);

var collector = sp.GetFakeLogCollector();
var record = collector.LatestRecord;
Assert.NotNull(record);

var latencyInfo = record.GetStructuredStateValue("LatencyInfo");
Assert.False(string.IsNullOrEmpty(latencyInfo));
Assert.StartsWith("v1.0,", latencyInfo);
Assert.Contains("TestServer", latencyInfo);
}

[Fact]
public async Task LatencyInfo_IsPopulated_WithConfigurationSection_AndWrapHandlersPipeline()
{
var configSection = new ConfigurationBuilder()
.AddInMemoryCollection(new Dictionary<string, string?>
{
{ "Logging:LogBody", "true" }
})
.Build()
.GetSection("Logging");

using var sp = new ServiceCollection()
.AddLatencyContext()
.AddRedaction()
.AddHttpClientLatencyTelemetry()
.AddHttpClient("test")
.ConfigurePrimaryHttpMessageHandler(() => new ServerNameStubHandler("TestServer"))
.AddExtendedHttpClientLogging(configSection, wrapHandlersPipeline: true)
.Services
.AddFakeLogging()
.BuildServiceProvider();

var client = sp.GetRequiredService<IHttpClientFactory>().CreateClient("test");

using var response = await client.GetAsync("http://localhost/api");
Assert.Equal(HttpStatusCode.OK, response.StatusCode);

var collector = sp.GetFakeLogCollector();
var record = collector.LatestRecord;
Assert.NotNull(record);

var latencyInfo = record.GetStructuredStateValue("LatencyInfo");
Assert.False(string.IsNullOrEmpty(latencyInfo));
Assert.StartsWith("v1.0,", latencyInfo);
}

[Fact]
public async Task LatencyInfo_IsPopulated_WithActionConfiguration_WhenLoggerDoesNotWrapHandlersPipeline()
{
using var sp = new ServiceCollection()
.AddLatencyContext()
.AddRedaction()
.AddHttpClientLatencyTelemetry()
.AddHttpClient("test")
.ConfigurePrimaryHttpMessageHandler(() => new ServerNameStubHandler("TestServer"))
.AddExtendedHttpClientLogging(o => o.LogBody = true, wrapHandlersPipeline: false)
.Services
.AddFakeLogging()
.BuildServiceProvider();

var client = sp.GetRequiredService<IHttpClientFactory>().CreateClient("test");

using var response = await client.GetAsync("http://localhost/api");
Assert.Equal(HttpStatusCode.OK, response.StatusCode);

var collector = sp.GetFakeLogCollector();
var record = collector.LatestRecord;
Assert.NotNull(record);

var latencyInfo = record.GetStructuredStateValue("LatencyInfo");
Assert.False(string.IsNullOrEmpty(latencyInfo));
Assert.StartsWith("v1.0,", latencyInfo);
}

[Fact]
public async Task LatencyInfo_IsNotPresent_WhenLatencyTelemetryNotAdded()
{
using var sp = new ServiceCollection()
.AddRedaction()
.AddExtendedHttpClientLogging()
.AddHttpClient("test")
.ConfigurePrimaryHttpMessageHandler(() => new ServerNameStubHandler("TestServer"))
.Services
.AddFakeLogging()
.BuildServiceProvider();

var client = sp.GetRequiredService<IHttpClientFactory>().CreateClient("test");

using var response = await client.GetAsync("http://localhost/api");
Assert.Equal(HttpStatusCode.OK, response.StatusCode);

var collector = sp.GetFakeLogCollector();
var record = collector.LatestRecord;
Assert.NotNull(record);

var latencyInfo = record.GetStructuredStateValue("LatencyInfo");
Assert.True(string.IsNullOrEmpty(latencyInfo));
}

private static IConfigurationSection GetConfigSection(HttpClientLatencyTelemetryOptions options)
{
return new ConfigurationBuilder()
Expand All @@ -237,14 +119,4 @@ private static IConfigurationSection GetConfigSection(HttpClientLatencyTelemetry
.Build()
.GetSection($"{nameof(HttpClientLatencyTelemetryOptions)}");
}

private sealed class ServerNameStubHandler(string serverName) : HttpMessageHandler
{
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
var response = new HttpResponseMessage(HttpStatusCode.OK);
response.Headers.TryAddWithoutValidation(TelemetryConstants.ServerApplicationNameHeader, serverName);
return Task.FromResult(response);
}
}
}
40 changes: 40 additions & 0 deletions ...es/Microsoft.Extensions.Http.Diagnostics.Tests/Logging/HttpClientLoggingExtensionsTest.cs
View file
Open in desktop
Comment thread
evgenyfedorov2 marked this conversation as resolved.
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

using System;
using System.Collections.Generic;
using System.Net;
using System.Net.Http;
using System.Threading;
using System.Threading.Tasks;
Expand Down Expand Up @@ -404,6 +405,45 @@ public void AddHttpClientLogging_ServiceCollection_CreatesClientSuccessfully()
Assert.NotNull(httpClient);
}

[Fact]
public async Task LatencyInfo_IsPopulated_WhenLoggerWrapsHandlersPipeline()
{
await using var sp = new ServiceCollection()
.AddLatencyContext()
.AddRedaction()
.AddHttpClientLatencyTelemetry()
.AddHttpClient("test")
.ConfigurePrimaryHttpMessageHandler(() => new ServerNameStubHandler("TestServer"))
Comment thread
rainsxng marked this conversation as resolved.
Outdated
.AddExtendedHttpClientLogging(wrapHandlersPipeline: true)
.Services
.AddFakeLogging()
.BuildServiceProvider();

var client = sp.GetRequiredService<IHttpClientFactory>().CreateClient("test");

using var response = await client.GetAsync("http://localhost/api");
Assert.Equal(HttpStatusCode.OK, response.StatusCode);

var collector = sp.GetFakeLogCollector();
var record = collector.LatestRecord;
Assert.NotNull(record);

var latencyInfo = record.GetStructuredStateValue("LatencyInfo");
Assert.False(string.IsNullOrEmpty(latencyInfo));
Assert.StartsWith("v1.0,", latencyInfo);
Assert.Contains("TestServer", latencyInfo);
}

private sealed class ServerNameStubHandler(string serverName) : HttpMessageHandler
{
protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
{
var response = new HttpResponseMessage(HttpStatusCode.OK);
response.Headers.TryAddWithoutValidation(TelemetryConstants.ServerApplicationNameHeader, serverName);
return Task.FromResult(response);
}
}

private static void EnsureSingleLogger<T>(IServiceProvider serviceProvider, string serviceKey)
where T : IHttpClientLogger
{
Expand Down
Loading