Skip to content

Conversation

@cartermp
Copy link
Contributor

@cartermp cartermp commented Sep 14, 2020

fixes #2926

@cartermp cartermp requested a review from brettfo September 14, 2020 22:01
@cartermp
Copy link
Contributor Author

Just to clarify, if I move the xml file in the directory that I think does setup definitions for, I get XML docs for FSharp.Core. So I know that works, it's just a question of if this is the correct fix

@brettfo
Copy link
Member

brettfo commented Sep 14, 2020

This change is the same as placing that XML file locally at C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\Common7\IDE\CommonExtensions\Microsoft\FSharp\FSharp.Core.xml, so if that manual step does what you want, then this will do what you want, too.

@cartermp
Copy link
Contributor Author

Yep, that's totes what I want. Here's the difference.

Before:

image

After:

image

My font is larger and different than the default btw

@cartermp cartermp merged commit 4d2419a into dotnet:main Sep 15, 2020
@dsyme
Copy link
Contributor

dsyme commented Sep 15, 2020

Thank you for fixing this!

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* Deploy FSharp.Core.xml in our IDE package

* yeet sigdata and optdata too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Intellisense and Quick Info do not show F# documentation in FSX files

4 participants