Skip to content

Correct IDE diagnostics and lifetimes for editing with #r package references #10160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 13 commits into from
Sep 20, 2020
Merged

Correct IDE diagnostics and lifetimes for editing with #r package references #10160

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c069beb
fix script editing perf
Sep 19, 2020
df2ca3b
fix script editing perf
Sep 19, 2020
928cf6d
one DependencyProvider per project
Sep 19, 2020
1edbffb
one DependencyProvider per project
Sep 19, 2020
a1f6298
one DependencyProvider per project
Sep 19, 2020
b432077
fix diagnostics in IDE
Sep 20, 2020
5767d43
fix fscomp
Sep 20, 2020
c3433d0
tooltips for script references
Sep 20, 2020
5258b88
merge main
Sep 20, 2020
24c13ac
update baseline
Sep 20, 2020
9a5db5b
fix test
Sep 20, 2020
1b7485c
fix tests
Sep 20, 2020
7341d45
fix tests
Sep 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
Don Syme committed Sep 20, 2020
commit 1b7485ca8681cdaa1d0c8538d8d7686a83d2cabd
15 changes: 10 additions & 5 deletions tests/FSharp.Compiler.Private.Scripting.UnitTests/FSharpScriptTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,21 +249,26 @@ printfn ""%A"" result
if line.Contains("error NU1101:") && line.Contains("FSharp.Really.Not.A.Package") then
found <- found + 1
outp.Add(line))
let _result, _errors = script.Eval("""#r "nuget:FSharp.Really.Not.A.Package" """)
Assert.True( (found = 1), "Expected to see output contains 'error NU1101:' and 'FSharp.Really.Not.A.Package'")
let result, errors = script.Eval("""#r "nuget:FSharp.Really.Not.A.Package" """)
Assert.True( (found = 0), "Did not expect to see output contains 'error NU1101:' and 'FSharp.Really.Not.A.Package'")
Assert.True( errors |> Seq.exists (fun error -> error.Message.Contains("error NU1101:")), "Expect to error containing 'error NU1101:'")
Assert.True( errors |> Seq.exists (fun error -> error.Message.Contains("FSharp.Really.Not.A.Package")), "Expect to error containing 'FSharp.Really.Not.A.Package'")

[<Fact>]
member __.``Eval script with invalid PackageName should fail immediately and resolve one time only``() =
use output = new RedirectConsoleOutput()
use script = new FSharpScript(additionalArgs=[|"/langversion:preview"|])
let mutable foundResolve = 0
output.OutputProduced.Add (fun line -> if line.Contains("Microsoft (R) Build Engine version") then foundResolve <- foundResolve + 1)
let _result, _errors =
output.OutputProduced.Add (fun line -> if line.Contains("error NU1101:") then foundResolve <- foundResolve + 1)
let result, errors =
script.Eval("""
#r "nuget:FSharp.Really.Not.A.Package"
#r "nuget:FSharp.Really.Not.Another.Package"
""")
Assert.True( (foundResolve = 1), (sprintf "Expected to see 'Microsoft (R) Build Engine version' only once actually resolved %d times" foundResolve))
Assert.True( (foundResolve = 0), (sprintf "Did not expected to see 'error NU1101:' in output" ))
Assert.Equal(2, (errors |> Seq.filter (fun error -> error.Message.Contains("error NU1101:")) |> Seq.length))
Assert.Equal(1, (errors |> Seq.filter (fun error -> error.Message.Contains("FSharp.Really.Not.A.Package")) |> Seq.length))
Assert.Equal(1, (errors |> Seq.filter (fun error -> error.Message.Contains("FSharp.Really.Not.Another.Package")) |> Seq.length))

[<Fact>]
member __.``ML - use assembly with ref dependencies``() =
Expand Down