Skip to content

fix(array): make the Array.length null exception containing the param… #10337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 2 commits into from
Oct 28, 2020
Merged

fix(array): make the Array.length null exception containing the param… #10337

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e7178
fix(array): make the Array.length null exception containing the param…
Oct 24, 2020
1cf1d37
fix(array): update ZeroToArrLength02.il.bsl
Oct 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(array): update ZeroToArrLength02.il.bsl
  • Loading branch information
Kerry Perret committed Oct 25, 2020
commit 1cf1d3771bd11b1b7bbcf381fa2b477e88795d46
73 changes: 33 additions & 40 deletions tests/fsharpqa/Source/Optimizations/ForLoop/ZeroToArrLength02.il.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@

// Microsoft (R) .NET Framework IL Disassembler. Version 4.6.1055.0
// Microsoft (R) .NET Framework IL Disassembler. Version 4.8.3928.0
// Copyright (c) Microsoft Corporation. All rights reserved.



// Metadata version: v4.0.30319
.assembly extern mscorlib
{
Expand All @@ -13,82 +10,78 @@
.assembly extern FSharp.Core
{
.publickeytoken = (B0 3F 5F 7F 11 D5 0A 3A ) // .?_....:
.ver 4:4:1:0
.ver 5:0:0:0
}
.assembly ZeroToArrLength02
{
.custom instance void [FSharp.Core]Microsoft.FSharp.Core.FSharpInterfaceDataVersionAttribute::.ctor(int32,
int32,
int32) = ( 01 00 02 00 00 00 00 00 00 00 00 00 00 00 00 00 )

// --- The following custom attribute is added automatically, do not uncomment -------
// .custom instance void [mscorlib]System.Diagnostics.DebuggableAttribute::.ctor(valuetype [mscorlib]System.Diagnostics.DebuggableAttribute/DebuggingModes) = ( 01 00 01 00 00 00 00 00 )

.hash algorithm 0x00008004
.ver 0:0:0:0
}
.mresource public FSharpSignatureData.ZeroToArrLength02
{
// Offset: 0x00000000 Length: 0x000001E0
// Offset: 0x00000000 Length: 0x0000020E
}
.mresource public FSharpOptimizationData.ZeroToArrLength02
{
// Offset: 0x000001E8 Length: 0x0000007B
// Offset: 0x00000218 Length: 0x0000007B
}
.module ZeroToArrLength02.dll
// MVID: {59B18AEE-A36B-03A7-A745-0383EE8AB159}
// MVID: {5F9557F9-A36B-03A7-A745-0383F957955F}
.imagebase 0x00400000
.file alignment 0x00000200
.stackreserve 0x00100000
.subsystem 0x0003 // WINDOWS_CUI
.corflags 0x00000001 // ILONLY
// Image base: 0x01550000


// Image base: 0x04D90000
// =============== CLASS MEMBERS DECLARATION ===================

.class public abstract auto ansi sealed ZeroToArrLength02
extends [mscorlib]System.Object
{
.custom instance void [FSharp.Core]Microsoft.FSharp.Core.CompilationMappingAttribute::.ctor(valuetype [FSharp.Core]Microsoft.FSharp.Core.SourceConstructFlags) = ( 01 00 07 00 00 00 00 00 )
.method public static void f1(int32[] arr) cil managed
{
// Code size 23 (0x17)
// Code size 34 (0x22)
.maxstack 5
.locals init ([0] int32 i)
.locals init ([0] int32 V_0,
[1] int32 i)
.language '{AB4F38C9-B6E6-43BA-BE3B-58080B2CCCE3}', '{994B45C4-E6E9-11D2-903F-00C04FA302A1}', '{5A869D0B-6611-11D3-BD2A-0000F80849BD}'
.line 6,6 : 5,41 'C:\\GitHub\\dsyme\\visualfsharp\\tests\\fsharpqa\\Source\\Optimizations\\ForLoop\\ZeroToArrLength02.fs'
.line 6,6 : 5,41 'C:\\Users\\Michelle\\Desktop\\Personal\\Repos\\fsharp\\tests\\fsharpqa\\source\\Optimizations\\ForLoop\\ZeroToArrLength02.fs'
IL_0000: ldc.i4.0
IL_0001: stloc.0
IL_0002: br.s IL_0010

IL_0001: stloc.1
IL_0002: ldarg.0
IL_0003: call int32 [FSharp.Core]Microsoft.FSharp.Collections.ArrayModule::Length<int32>(!!0[])
IL_0008: ldc.i4.1
IL_0009: sub
IL_000a: stloc.0
IL_000b: ldloc.0
IL_000c: ldloc.1
IL_000d: blt.s IL_0021
.line 7,7 : 9,21 ''
IL_0004: ldarg.0
IL_0005: ldloc.0
IL_0006: ldloc.0
IL_0007: stelem [mscorlib]System.Int32
IL_000c: ldloc.0
IL_000d: ldc.i4.1
IL_000e: add
IL_000f: stloc.0
IL_000f: ldarg.0
IL_0010: ldloc.1
IL_0011: ldloc.1
IL_0012: stelem [mscorlib]System.Int32
IL_0017: ldloc.1
IL_0018: ldc.i4.1
IL_0019: add
IL_001a: stloc.1
.line 6,6 : 5,41 ''
IL_0010: ldloc.0
IL_0011: ldarg.0
IL_0012: ldlen
IL_0013: conv.i4
IL_0014: blt.s IL_0004

IL_0016: ret
IL_001b: ldloc.1
IL_001c: ldloc.0
IL_001d: ldc.i4.1
IL_001e: add
IL_001f: bne.un.s IL_000f
IL_0021: ret
} // end of method ZeroToArrLength02::f1

} // end of class ZeroToArrLength02

.class private abstract auto ansi sealed '<StartupCode$ZeroToArrLength02>'.$ZeroToArrLength02
extends [mscorlib]System.Object
{
} // end of class '<StartupCode$ZeroToArrLength02>'.$ZeroToArrLength02


// =============================================================

// *********** DISASSEMBLY COMPLETE ***********************