Skip to content

Sequentialize GetAllUsesOfAllSymolsInFile #10357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cartermp merged 11 commits into from
Nov 6, 2020
Merged

Sequentialize GetAllUsesOfAllSymolsInFile #10357

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
de84519
Add benchmarks
cartermp Oct 30, 2020
950805b
ServiceAnalysis minor perf improvements
cartermp Oct 30, 2020
486df15
Add comment
cartermp Oct 30, 2020
058973c
More updates - better results
cartermp Oct 30, 2020
48a9914
Sequentialize GetAllUsesOfAllSymbols and do other perf updates
cartermp Oct 31, 2020
62a9289
Style
cartermp Oct 31, 2020
96efbea
surface and clean up diff
cartermp Oct 31, 2020
7ad4895
Fix regression
cartermp Oct 31, 2020
897147a
area
cartermp Oct 31, 2020
98675a8
Merge branch 'main' into analysis-updates
cartermp Nov 5, 2020
f12b419
build update
cartermp Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
build update
  • Loading branch information
@cartermp
cartermp committed Nov 5, 2020
commit f12b41967517b2e5ad36f47fbb7676b44741f7ab
2 changes: 1 addition & 1 deletion tests/service/Common.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ let assertHasSymbolUsages (names: string list) (results: FSharpCheckFileResults)

let findSymbolUseByName (name: string) (results: FSharpCheckFileResults) =
getSymbolUses results
|> Array.find (fun symbolUse ->
|> Seq.find (fun symbolUse ->
match getSymbolName symbolUse.Symbol with
| Some symbolName -> symbolName = name
| _ -> false)
Expand Down