Skip to content

Fix extern declaration accessibility #10399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 6 commits into from
Nov 7, 2020
Merged

Fix extern declaration accessibility #10399

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
931f67d
Keep extern declaration access
auduchinok Nov 6, 2020
3eca1d8
Add test
auduchinok Nov 6, 2020
f1d5071
Simplify test
auduchinok Nov 6, 2020
fcfd224
Check no modifier, explicit public modifier
auduchinok Nov 6, 2020
0bad662
Cleanup
auduchinok Nov 6, 2020
39a7c6f
Fix test
auduchinok Nov 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Check no modifier, explicit public modifier
  • Loading branch information
@auduchinok
auduchinok committed Nov 6, 2020
commit fcfd2245f29772f20ce4a4b2d69fba9934465127
36 changes: 26 additions & 10 deletions tests/service/Symbols.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,16 +61,32 @@ match "foo" with
module ExternDeclarations =
[<Test>]
let ``Access modifier`` () =
let parseResults, checkResults = getParseAndCheckResults "extern int private f()"

match getSingleModuleLikeDecl parseResults.ParseTree with
| SynModuleOrNamespace (decls = [SynModuleDecl.Let (_, [Binding (accessibility = accessibility)], _)]) ->
accessibility |> should equal (Some SynAccess.Private)
| _ -> failwith "Couldn't get f"

match findSymbolByName "f" checkResults with
| :? FSharpMemberOrFunctionOrValue as mfv -> mfv.Accessibility.IsPrivate |> should equal true
| _ -> failwith "Couldn't get f"
let parseResults, checkResults = getParseAndCheckResults """
extern int a()
extern int public b()
extern int private c()
"""
let (SynModuleOrNamespace (decls = decls)) = getSingleModuleLikeDecl parseResults.ParseTree

[ None
Some SynAccess.Public
Some SynAccess.Private ]
|> List.zip decls
|> List.iter (fun (actual, (expected)) ->
match actual with
| SynModuleDecl.Let (_, [Binding (accessibility = access)], _) -> access |> should equal expected
| decl -> failwithf "unexpected decl: %O" decl)

[ "a", (true, false, false, false)
"b", (true, false, false, false)
"c", (false, false, false, true) ]
|> List.iter (fun (name, expectedAccess) ->
match findSymbolByName name checkResults with
| :? FSharpMemberOrFunctionOrValue as mfv ->
let access = mfv.Accessibility
(access.IsPublic, access.IsProtected, access.IsInternal, access.IsPrivate)
|> should equal expectedAccess
| _ -> failwith "Couldn't get f")


module XmlDocSig =
Expand Down