Add RemoveReturnOrYield code fixer #10530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cartermp
commented
Nov 23, 2020
Comment on lines
16
to
29
| [<AutoOpen>] | ||
| module Traversal = | ||
| type FSharpParseFileResults with | ||
| member scope.TryRangeOfExprInYieldOrReturn pos = | ||
| match scope.ParseTree with | ||
| | Some parseTree -> | ||
| AstTraversal.Traverse(pos, parseTree, { new AstTraversal.AstVisitorBase<_>() with | ||
| member __.VisitExpr(_path, _, defaultTraverse, expr) = | ||
| match expr with | ||
| | SynExpr.YieldOrReturn(_, expr, range) | ||
| | SynExpr.YieldOrReturnFrom(_, expr, range) when rangeContainsPos range pos -> | ||
| Some expr.Range | ||
| | _ -> defaultTraverse expr }) | ||
| | None -> None |
Contributor
Author
There was a problem hiding this comment.
This can be moved into thecompiler service and with tests, I just wanted to localize it for easreof development
KevinRansom
approved these changes
Dec 7, 2020
Contributor
Author
|
Will merge once green |
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Feb 23, 2021
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another simple one. I should probably move the type extension into the compiler service proper, but first I wanted to check that this is all good.
This also supports the
return!andyield!variants, and like, nobody will ever do that, but it was trivial to support it.