Skip to content

Cherry Pick into 16.9 - Track the signaturehelp session kind in signature help (#10970) #10972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinRansom merged 2 commits into from
Feb 1, 2021
Merged

Cherry Pick into 16.9 - Track the signaturehelp session kind in signature help (#10970) #10972

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
594662a
Track the signaturehelp session kind in signature help (#10970)
cartermp Jan 29, 2021
644227f
Update SignatureHelp.fs
cartermp Jan 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update SignatureHelp.fs
  • Loading branch information
@cartermp
cartermp authored Jan 29, 2021
commit 644227fb90737503602df50fe44d9c82818327a2
4 changes: 2 additions & 2 deletions vsintegration/src/FSharp.Editor/Completion/SignatureHelp.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ type internal FSharpSignatureHelpProvider
// Generally ' ' indicates a function application, but it's also used commonly after a comma in a method call.
// This means that the adjusted position relative to the caret could be a ',' or a ')' or '>',
// which would mean we're already inside of a method call - not a function argument. So we bail if that's the case.
| Some ' ', None when adjustedColumnChar <> ',' && adjustedColumnChar <> '(' && adjustedColumnChar <> '<' ->
| Some ' ', None when adjustedColumnString <> "," && adjustedColumnString <> "(" && adjustedColumnString <> "<" ->
return!
FSharpSignatureHelpProvider.ProvideParametersAsyncAux(
parseResults,
Expand All @@ -494,7 +494,7 @@ type internal FSharpSignatureHelpProvider
caretPosition,
adjustedColumnInSource,
filePath)
| _, Some FunctionApplication when adjustedColumnChar <> ',' && adjustedColumnChar <> '(' && adjustedColumnChar <> '<' ->
| _, Some FunctionApplication when adjustedColumnString <> "," && adjustedColumnString <> "(" && adjustedColumnString <> "<" ->
return!
FSharpSignatureHelpProvider.ProvideParametersAsyncAux(
parseResults,
Expand Down