-
Notifications
You must be signed in to change notification settings - Fork 842
RequireArgumentName - FS-1095 (experimental branch) #11368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RequireArgumentName - FS-1095 (experimental branch) #11368
Conversation
7543112 to
2b08d9c
Compare
…or provided methods.
… it in CheckMethInfoAttributes
4dfd2f3 to
e278e00
Compare
|
I do like this as an optional thing! |
|
@cartermp, can you confirm this one also goes behind language version flag and should ship in preview? What is the bar for using language version guards? If that process is solidified, it would be good to describe it in the README.md of fslang-design repository. |
|
Hey @smoothdeveloper, this PR has a frightening number of conflicts - do you still want to continue working on this? |
I'm slightly late to the party, usually all breaking changes (often, even if they are fixes) go under the language flag, and I think that all new features should too. If we don't, it defeats the whole purpose of language versions. Ideally subset of features for specific language version should not change with time, so people will be sure that by using specific version they'll get specific behaviour.
So, I would say - yes. |
|
@smoothdeveloper , hey mate, Once again thanks Kevin |
This is my experimental branch for https://github.com/fsharp/fslang-design/blob/master/drafts/FS-1095-requirenamedargumentattribute.md.
Mostly to get feedback from CI, and maybe getting patches & reviews along the line.