Skip to content

Check qualifier reported types after filtering errors #11909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TIHan merged 1 commit into from
Aug 4, 2021
Merged

Check qualifier reported types after filtering errors #11909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/fsharp/service/FSharpCheckerResults.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,13 +542,14 @@ type internal TypeCheckInfo
not (isFunTy nenv.DisplayEnv.g ty))
|> Seq.toArray

let thereWereSomeQuals = not (Array.isEmpty quals)
// filter out errors

let quals = quals
|> Array.filter (fun (ty,nenv,_,_) ->
let denv = nenv.DisplayEnv
not (isTyparTy denv.g ty && (destTyparTy denv.g ty).IsFromError))

let thereWereSomeQuals = not (Array.isEmpty quals)
thereWereSomeQuals, quals

/// obtains captured typing for the given position
Expand Down