fix regression in debug codegen #12021
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11957 caused a regression in debug code generation in an obscure case used by the debug-mode compiler
For a loop
The pipeline was being incorrectly marked as "has no effect". Normally effect information doesn't matter in debug code generation, however in one case (for loops) the construct was being omitted altogether if the body was judged to have no effect.
This meant the debug-mode compiler we build in our tree was malfunctioning. This fixes this problem.
@brettfo We should probably run at least one of our test suites in debug mode.