Skip to content

Add Reference Assembly support - 'refonly' and 'refout' compiler options #12334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 131 commits into from
Apr 20, 2022
Merged

Add Reference Assembly support - 'refonly' and 'refout' compiler options #12334

Changes from 1 commit
Commits
Show all changes
131 commits
Select commit Hold shift + click to select a range
2411f75
Adding 'refonly' command line option
TIHan May 4, 2021
1b6dc26
Added a simple test, but it needs to fail
TIHan May 4, 2021
ee89986
We need to emit two kinds of reference assemblies. one with optimizat…
TIHan May 4, 2021
9dcdbb0
Passing reference assembly flag to IlxGen
TIHan May 4, 2021
84cd6a8
Emit ReferenceAssemblyAttribute
TIHan May 4, 2021
3a0a7be
Added ref-assembly rules for private and internal methods
TIHan May 4, 2021
5d78b77
use --refonly for now
TIHan May 4, 2021
2f1af9b
Use HasFSharpAttribute
TIHan May 4, 2021
512743c
Added a failing test
TIHan May 4, 2021
4af859b
Test passes
TIHan May 4, 2021
6b5c032
Trying to handle anonymous record types
TIHan May 5, 2021
84354ba
Cleaning up. Using ILMemberAccess instead of Accessibility due to how…
TIHan May 5, 2021
6d93c92
Using notlazy
TIHan May 5, 2021
c31ce72
Added another comment
TIHan May 5, 2021
0d02203
Added mkDummyParameterVal
TIHan May 5, 2021
8f5cbf5
Using taccessPublic
TIHan May 5, 2021
daf1847
More cleanup
TIHan May 5, 2021
9d0c7f6
Minor comment update
TIHan May 5, 2021
47d3b5a
more cleanup
TIHan May 5, 2021
5e4460e
merging
TIHan May 10, 2021
3468094
Adding FreeAnonRecdTypeInfos set
TIHan May 10, 2021
23d0da7
Adding options
TIHan May 10, 2021
8a1504f
Flowing free anonrecdtypeinfos
TIHan May 10, 2021
d7e491e
Fixing build
TIHan May 10, 2021
7ff20d6
Tests pass. Able to emit partial ref assembly with anon recds
TIHan May 10, 2021
a023c38
Minor rename
TIHan May 10, 2021
6801573
Added a failing test
TIHan May 11, 2021
91dbaa0
Added failing test
TIHan May 11, 2021
4931062
Simpler handling of building lambdas
TIHan May 11, 2021
e5c1cc8
Trying to figure out default param names
TIHan May 11, 2021
bb26684
Adding TryEmitReferenceAssembly
TIHan May 11, 2021
7415f4a
Merge remote-tracking branch 'remote/main' into ref-assembly-output
TIHan May 12, 2021
ee33c6d
Moving some reference assembly generation rules to ilwrite
TIHan May 13, 2021
180f339
Fixing build
TIHan May 13, 2021
e36c696
Added new compiler option '--refout:<file>'
TIHan May 18, 2021
32044c5
Fixing one of the tests
TIHan May 18, 2021
3088747
refonly/refout should only be part of fsc
TIHan May 18, 2021
f475e58
Merge remote-tracking branch 'remote/main' into ref-assembly-output
TIHan May 18, 2021
cfa275c
Updating help baseline
TIHan May 18, 2021
1604fa0
Merge remote-tracking branch 'remote/main' into ref-assembly-output
TIHan Jun 3, 2021
6f6b2a6
Merging
TIHan Jun 3, 2021
f4c9980
fixed build
TIHan Jun 3, 2021
193ba49
Fixing build. Added basic deterministic test
TIHan Jun 3, 2021
4793882
Failing determinism test
TIHan Jun 3, 2021
69fb788
Added DeterministicTests
TIHan Jun 3, 2021
067091b
Adding determinism task for CI
TIHan Jun 3, 2021
5e14bbc
moving yml to pipelines
TIHan Jun 3, 2021
2a9bcf1
Trying to fix determinism CI
TIHan Jun 3, 2021
7a5ba80
quick fix
TIHan Jun 3, 2021
cb85986
removing job
TIHan Jun 3, 2021
cebcc6c
Trying to fix ci
TIHan Jun 3, 2021
e4c046f
Removing this
TIHan Jun 3, 2021
3bdd39d
Turn on determinism for build
TIHan Jun 3, 2021
c0c83e4
Trying to fix
TIHan Jun 3, 2021
d4984eb
This works
TIHan Jun 3, 2021
1b3fdcf
Determinism
TIHan Jun 3, 2021
b6ac933
Building
TIHan Jun 3, 2021
447ab7a
Forgot to run test
TIHan Jun 3, 2021
2e4f679
Adding job
TIHan Jun 4, 2021
6f22cb8
Trying to fix job
TIHan Jun 4, 2021
50a041d
Remove job
TIHan Jun 4, 2021
78f53ac
Trying to figure out jobs
TIHan Jun 4, 2021
222dad3
Updating job
TIHan Jun 4, 2021
b22c2e5
Fixing determinism job
TIHan Jun 4, 2021
f1f2cc6
Fixing job
TIHan Jun 4, 2021
3c2d413
Update test-determinism.ps1
TIHan Jun 4, 2021
246bcfe
Update FSharp.Profiles.props
TIHan Jun 4, 2021
1da9044
Update test-determinism.ps1
TIHan Jun 4, 2021
9babedc
Update FSharpBuild.Directory.Build.props
TIHan Jun 4, 2021
c353628
Merged with main
TIHan Jul 28, 2021
2e6caaa
Merge branch 'ref-assembly-output' of github.com:TIHan/visualfsharp i…
TIHan Jul 28, 2021
62c3254
Merge branch 'main' into ref-assembly-output
vzarytovskii Aug 5, 2021
a452cba
Merge branch 'main' into ref-assembly-output
vzarytovskii Aug 9, 2021
19e9ce5
Merged with main
TIHan Aug 25, 2021
eac93e3
Trying to fix build
TIHan Aug 25, 2021
ee90edc
Merge branch 'ref-assembly-output' of github.com:TIHan/visualfsharp i…
TIHan Aug 25, 2021
ee77c70
Trying to fix build
TIHan Aug 25, 2021
f868a05
fixing build
TIHan Aug 25, 2021
e4b2e1e
Fixing build
TIHan Aug 25, 2021
70c2fb1
fixing build
TIHan Aug 25, 2021
a188671
Fixing build
TIHan Aug 25, 2021
ddd4103
Remove comment as it is not accurate
TIHan Aug 25, 2021
d29ffde
Removed generating metadata assembly for IDEs
TIHan Nov 4, 2021
eb998bf
Merged main. Removed metadataOnly changes in IlxGen
TIHan Nov 4, 2021
2284b7c
Fixing build
TIHan Nov 4, 2021
4873683
Removing tests
TIHan Nov 4, 2021
0d453b5
Update ParseAndCheckInputs.fs
TIHan Nov 4, 2021
c1bc0f7
Update TypedTree.fs
TIHan Nov 4, 2021
a461988
Fixing build
TIHan Nov 4, 2021
dca1a16
Update TypedTreeOps.fs
TIHan Nov 4, 2021
ed1bdc0
Fixing build
TIHan Nov 4, 2021
9d5c0d2
Fixing build
TIHan Nov 4, 2021
919c100
Fixing build
TIHan Nov 4, 2021
575d38a
Fixing build
TIHan Nov 4, 2021
aea1908
Merge branch 'main' into ref-assembly-output-part1
vzarytovskii Nov 25, 2021
c124e18
Merged 'upstream/main'
vzarytovskii Dec 8, 2021
c90d810
Update baseline for fcs 'help' test
vzarytovskii Dec 10, 2021
18717bc
Merge branch 'ref-assembly-output-part1' of https://github.com/tihan/…
vzarytovskii Dec 10, 2021
460e408
Added a test for '--refout', with outout and IL verification
vzarytovskii Dec 10, 2021
01bf4d9
Added tests to verify that static linking and refassemblies cannot be…
vzarytovskii Dec 10, 2021
42b783d
Add mvid test for refonly + private members. It is failing on purpose…
vzarytovskii Dec 14, 2021
1104455
WIP: Add some more to the tests
vzarytovskii Dec 15, 2021
f12e73b
Added more tests for MVID
vzarytovskii Dec 15, 2021
70ffc39
wip
vzarytovskii Dec 15, 2021
bafd958
Added some todos + have more readable canGenMethodDef
vzarytovskii Jan 3, 2022
94d29b7
Add some more tests
vzarytovskii Jan 4, 2022
1c39033
Merge remote-tracking branch 'upstream/main' into ref-assembly-output…
vzarytovskii Jan 10, 2022
6ef6eea
[WIP]: ignore properties if we don't have getter/setter, or we don't …
vzarytovskii Jan 25, 2022
e701883
Don't generate private types, generate nested internal types only if …
vzarytovskii Jan 26, 2022
dad0c8c
Merged upstream/main
vzarytovskii Jan 26, 2022
a93d820
Merge fix
vzarytovskii Jan 26, 2022
591cfb6
Another fix after merge + added more internal tests
vzarytovskii Jan 26, 2022
ad1e2c0
Fixed test framework after merge (output directory). Add check whethe…
vzarytovskii Jan 28, 2022
00ed291
Merge branch 'main' of https://github.com/dotnet/fsharp into ref-asse…
dsyme Jan 31, 2022
990e09b
Emit fields when the type is struct. Always emit types
vzarytovskii Feb 3, 2022
0e9c3ad
Merge branch 'ref-assembly-output-part1' of https://github.com/tihan/…
vzarytovskii Feb 3, 2022
f552651
WIP: added isAttribute to ILTypeRef if type extends Attribute
vzarytovskii Feb 3, 2022
22f89e5
Fix properties generation, fix generating getter/setter for attributes
vzarytovskii Feb 7, 2022
48f91d9
Only check properties to generate if we are emitting reference assembly
vzarytovskii Feb 7, 2022
095987d
Fixed surface area tests
vzarytovskii Feb 8, 2022
f204e20
Adjusted baselines for IL tests. Fixed events generation.
vzarytovskii Feb 14, 2022
b90c2fd
Merge branch 'ref-assembly-output-part1' of https://github.com/tihan/…
vzarytovskii Feb 14, 2022
7cf2676
Cleanup unused yaml files
vzarytovskii Feb 14, 2022
f1a7ff4
Fixed docs for ILMemberAccess
vzarytovskii Feb 28, 2022
2b7a114
Merge 'upstream/main'
vzarytovskii Mar 23, 2022
033a112
Update message + rename property for ILTypeDef to be more clear
vzarytovskii Mar 25, 2022
1b4ff9d
Surface area tests
vzarytovskii Mar 28, 2022
74ff369
Fixed baseline error message
vzarytovskii Mar 31, 2022
7ba8563
Merge remote-tracking branch 'upstream/main' into ref-assembly-output…
vzarytovskii Apr 20, 2022
51e9d5a
After-merge fixes
vzarytovskii Apr 20, 2022
897d9c1
Fix tests
vzarytovskii Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor comment update
  • Loading branch information
@TIHan
TIHan committed May 5, 2021
commit 9d0c7f61e18d8c76a3474d63cd36e4cd78450cc7
2 changes: 1 addition & 1 deletion src/fsharp/ParseAndCheckInputs.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,7 @@ let createDummyModuleOrNamespaceExprWithSig g (mty: ModuleOrNamespaceType) =
]
ModuleOrNamespaceExprWithSig(mty, expr, range0)

/// Similar to 'createDummyTypedImplFile', only diffference is that there are no definitions and is not used to emit any kind of assembly.
/// Similar to 'createDummyTypedImplFile', only diffference is that there are no definitions and is not used for emitting any kind of assembly.
let createEmptyDummyTypedImplFile qualNameOfFile mty =
let dummyExpr = ModuleOrNamespaceExprWithSig.ModuleOrNamespaceExprWithSig(mty, ModuleOrNamespaceExpr.TMDefs [], range0)
TypedImplFile.TImplFile(qualNameOfFile, [], dummyExpr, false, false, StampMap.Empty)
Expand Down