Fix bug 12333 #12337
Merged
Fix bug 12333 #12337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks like some minor baseline IL tests need to be updated. |
TIHan
approved these changes
Nov 5, 2021
vzarytovskii
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for #12333
The fix in #6899 missed a case - We represent zero values in two ways
Simple constants like integers getExpr.Const (Const.Zero, _, _) . These are emitted near line 6374 of IlxGen.fs
"ilzero" ILASM nodes EI_ilzero. These come from Unchecked.defaultof which is what we generate for "ColorF()" default struct initializers. These go through GenDefaultValue in IlxGen and create a new temp local which we assume is zero init.
Bug #6899 was about cases where for (1) we were not zero-init'ing in code that can take backward branches (loops and let rec tailcalls). However for (2) we can also get exposed to the same problem
Note the bug only occurs for
(a)
let mutableinitialized using struct default initializers in loops(b) there are enough structs around to get to reuse the initialization temporary later on.
I'll add the test case, and let CI run through and see if exist tests catch this for codegen