remove ENABLE_MONO_SUPPORT #13531
Merged
remove ENABLE_MONO_SUPPORT #13531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzarytovskii
approved these changes
Jul 20, 2022
nosami
approved these changes
Jul 20, 2022
Contributor
|
Looks like this caused regression #13944 - will take a look why |
dsyme
reviewed
Sep 21, 2022
|
|
||
| #if RESIDENT_COMPILER | ||
| if runningOnMono && hasArgument "resident" argv then | ||
| if hasArgument "resident" argv then |
Contributor
There was a problem hiding this comment.
This section could have been removed as "running on mono" is always false now
dsyme
reviewed
Sep 21, 2022
| let mutable enableConsoleKeyProcessing = | ||
| // Mono on Win32 doesn't implement correct console processing | ||
| not (runningOnMono && Environment.OSVersion.Platform = PlatformID.Win32NT) | ||
| not (Environment.OSVersion.Platform = PlatformID.Win32NT) |
Contributor
There was a problem hiding this comment.
runningOnMono is always false, so this should have become let mutable enableConsoleKeyProcessing = true
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13443
Code cleanup ... remove some dead code related to support for the old mono runtime.