Skip to content

Speed up Constraint Solver's overload resolution #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsyme merged 12 commits into from
Oct 18, 2016
Merged

Speed up Constraint Solver's overload resolution #1530

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
73f67ab
Assume the constraint is solved before trying each overload.
gusty Sep 11, 2016
02e52b5
Defer transact member solution.
Sep 18, 2016
5be2aaf
Fix previous commit.
gusty Sep 18, 2016
189e560
Refactor with an additional function.
Sep 18, 2016
aec3cea
Remove unused parameter.
Sep 18, 2016
8fd49a1
Fix test by removing duplicate error message.
Sep 18, 2016
a1a60cf
Add comment.
gusty Sep 19, 2016
db27c64
Try to reproduce #351
forki Sep 19, 2016
48262b2
Commit cx solution right after the shortcut.
gusty Sep 20, 2016
68fc18e
Merge remote-tracking branch 'upstream/master'
Sep 23, 2016
d4dd918
Merge remote-tracking branch 'upstream/master'
Sep 24, 2016
04c5ef1
Merge remote-tracking branch 'upstream/master'
Sep 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix previous commit.
  • Loading branch information
@gusty
gusty authored Sep 18, 2016
commit 5be2aaf8d458fde0af1c0b9cc0040cd1c58c5a6d
2 changes: 1 addition & 1 deletion src/fsharp/TypeChecker.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5293,7 +5293,7 @@ and TcPatterns warnOnUpper cenv env vFlags s argtys args =
and solveTypAsError cenv denv m ty =
let ty2 = NewErrorType ()
assert((destTyparTy cenv.g ty2).IsFromError)
SolveTypEqualsTypKeepAbbrevs (MakeConstraintSolverEnv ContextInfo.NoContext cenv.css m denv) 0 m NoTrace ty ty2 |> ignore
SolveTypEqualsTypKeepAbbrevs (MakeConstraintSolverEnv ContextInfo.NoContext cenv.css m denv) 0 m NoTrace None ty ty2 |> ignore

and RecordNameAndTypeResolutions_IdeallyWithoutHavingOtherEffects cenv env tpenv expr =
// This function is motivated by cases like
Expand Down