Skip to content

More VS cleanup #15954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 25 commits into from
Oct 10, 2023
Merged

More VS cleanup #15954

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
d0ed695
wip
vzarytovskii Aug 30, 2023
f1778eb
wip
vzarytovskii Sep 8, 2023
a94bb5f
wip
vzarytovskii Sep 8, 2023
c24a1a3
wip
vzarytovskii Sep 8, 2023
cc5f92b
wip
vzarytovskii Sep 11, 2023
38ea540
Fantomas
vzarytovskii Sep 11, 2023
709d6d5
more wip
vzarytovskii Sep 11, 2023
18b07a5
wip: cache semantic highlightings for opened docs
vzarytovskii Sep 11, 2023
98c2a5a
more wip
vzarytovskii Sep 11, 2023
73877dc
wip
vzarytovskii Sep 12, 2023
524c12c
wip
vzarytovskii Sep 12, 2023
a6a1664
fantomas
vzarytovskii Sep 12, 2023
9116623
fix external navigation
vzarytovskii Sep 14, 2023
a5ac09d
wip
vzarytovskii Sep 18, 2023
27cb2f3
wip
vzarytovskii Sep 18, 2023
6419d39
Merge
vzarytovskii Sep 18, 2023
227c6e2
Merge remote-tracking branch 'upstream/main' into more-cancellable-ta…
vzarytovskii Sep 18, 2023
4901a68
wip
vzarytovskii Sep 20, 2023
bd4baba
Automated command ran: fantomas
github-actions[bot] Sep 20, 2023
cbe52f2
Merge branch 'main' into more-cancellable-tasks3
0101 Oct 2, 2023
29b7c4b
wip
vzarytovskii Oct 9, 2023
a40c0e2
Merge branch 'more-cancellable-tasks3' of https://github.com/vzarytov…
vzarytovskii Oct 9, 2023
dcbdb23
wip
vzarytovskii Oct 9, 2023
13dd4ba
Merge branch 'main' into more-cancellable-tasks3
vzarytovskii Oct 9, 2023
5130812
Automated command ran: fantomas
github-actions[bot] Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fantomas
  • Loading branch information
@vzarytovskii
vzarytovskii committed Sep 12, 2023
commit a6a16640abea427300aa1a203911da14660a5016
6 changes: 4 additions & 2 deletions vsintegration/src/FSharp.Editor/Navigation/GoToDefinition.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -704,7 +704,7 @@ type internal FSharpNavigation(metadataAsSource: FSharpMetadataAsSourceService,
TelemetryReporter.ReportSingleEventWithDuration(TelemetryEvents.GoToDefinition, [||])

let gtd = GoToDefinition(metadataAsSource)
let gtdTask = gtd.FindDefinitionAsync(initialDoc, position) cancellationToken
let gtdTask = gtd.FindDefinitionAsync (initialDoc, position) cancellationToken

gtdTask.Wait()

Expand All @@ -714,7 +714,9 @@ type internal FSharpNavigation(metadataAsSource: FSharpMetadataAsSourceService,
gtd.NavigateToItem(navItem, cancellationToken) |> ignore
true
| ValueSome (FSharpGoToDefinitionResult.ExternalAssembly (targetSymbolUse, metadataReferences), _) ->
gtd.NavigateToExternalDeclaration(targetSymbolUse, metadataReferences, cancellationToken) |> ignore
gtd.NavigateToExternalDeclaration(targetSymbolUse, metadataReferences, cancellationToken)
|> ignore

true
| _ -> false
else
Expand Down