Skip to content

Bugfix: Standalone dotlambda just before EOF #16240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psfinaki merged 10 commits into from
Nov 10, 2023
Merged

Bugfix: Standalone dotlambda just before EOF #16240

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5287481
failing test
T-Gro Nov 8, 2023
5f71856
errors removed
T-Gro Nov 8, 2023
71a43db
move tests into expression folder
T-Gro Nov 8, 2023
e9e9b11
simplify parser rules
T-Gro Nov 8, 2023
085dc50
get them back
T-Gro Nov 8, 2023
e947086
Simplifying ruleset
T-Gro Nov 9, 2023
7e96db3
Validating incorrect usage in typechecking, not in parsing like before
T-Gro Nov 9, 2023
6d80c16
Moving tests into Expression folder
T-Gro Nov 9, 2023
dff2b37
removing explicit precedence rule for dot_lambda
T-Gro Nov 9, 2023
3801f3f
put %prec back, tests were failing
T-Gro Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Moving tests into Expression folder
  • Loading branch information
@T-Gro
T-Gro committed Nov 9, 2023
commit 6d80c16887c059569bd34bd70a816a3b6813aef4
11 changes: 0 additions & 11 deletions tests/service/data/SyntaxTree/DotLambda/WithoutUnderscore.fs.bsl
View file
Open in desktop

This file was deleted.

0 ...ArgumentExpressionInInnerAppExpression.fs → ...ArgumentExpressionInInnerAppExpression.fs
View file
Open in desktop
File renamed without changes.
8 changes: 5 additions & 3 deletions ...mentExpressionInInnerAppExpression.fs.bsl → ...mentExpressionInInnerAppExpression.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/ArgumentExpressionInInnerAppExpression.fs", false,
QualifiedNameOfFile ArgumentExpressionInInnerAppExpression, [], [],
("/root/Expression/DotLambda_ArgumentExpressionInInnerAppExpression.fs",
false,
QualifiedNameOfFile DotLambda_ArgumentExpressionInInnerAppExpression, [],
[],
[SynModuleOrNamespace
([ArgumentExpressionInInnerAppExpression], false, AnonModule,
([DotLambda_ArgumentExpressionInInnerAppExpression], false, AnonModule,
[Let
(false,
[SynBinding
Expand Down
0 ...Lambda/FunctionWithUnderscoreDotLambda.fs → ...Lambda_FunctionWithUnderscoreDotLambda.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...da/FunctionWithUnderscoreDotLambda.fs.bsl → ...da_FunctionWithUnderscoreDotLambda.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/FunctionWithUnderscoreDotLambda.fs", false,
QualifiedNameOfFile FunctionWithUnderscoreDotLambda, [], [],
("/root/Expression/DotLambda_FunctionWithUnderscoreDotLambda.fs", false,
QualifiedNameOfFile DotLambda_FunctionWithUnderscoreDotLambda, [], [],
[SynModuleOrNamespace
([FunctionWithUnderscoreDotLambda], false, AnonModule,
([DotLambda_FunctionWithUnderscoreDotLambda], false, AnonModule,
[Let
(false,
[SynBinding
Expand Down
0 ...Lambda/NestedPropertiesAfterUnderscore.fs → ...Lambda_NestedPropertiesAfterUnderscore.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...da/NestedPropertiesAfterUnderscore.fs.bsl → ...da_NestedPropertiesAfterUnderscore.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/NestedPropertiesAfterUnderscore.fs", false,
QualifiedNameOfFile NestedPropertiesAfterUnderscore, [], [],
("/root/Expression/DotLambda_NestedPropertiesAfterUnderscore.fs", false,
QualifiedNameOfFile DotLambda_NestedPropertiesAfterUnderscore, [], [],
[SynModuleOrNamespace
([NestedPropertiesAfterUnderscore], false, AnonModule,
([DotLambda_NestedPropertiesAfterUnderscore], false, AnonModule,
[Let
(false,
[SynBinding
Expand Down
0 ...da/NotAllowedFunctionExpressionWithArg.fs → ...da_NotAllowedFunctionExpressionWithArg.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...otAllowedFunctionExpressionWithArg.fs.bsl → ...otAllowedFunctionExpressionWithArg.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/NotAllowedFunctionExpressionWithArg.fs", false,
QualifiedNameOfFile NotAllowedFunctionExpressionWithArg, [], [],
("/root/Expression/DotLambda_NotAllowedFunctionExpressionWithArg.fs", false,
QualifiedNameOfFile DotLambda_NotAllowedFunctionExpressionWithArg, [], [],
[SynModuleOrNamespace
([NotAllowedFunctionExpressionWithArg], false, AnonModule,
([DotLambda_NotAllowedFunctionExpressionWithArg], false, AnonModule,
[Let
(false,
[SynBinding
Expand Down
0 .../data/SyntaxTree/DotLambda/TopLevelLet.fs → ...xTree/Expression/DotLambda_TopLevelLet.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...a/SyntaxTree/DotLambda/TopLevelLet.fs.bsl → ...e/Expression/DotLambda_TopLevelLet.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/TopLevelLet.fs", false, QualifiedNameOfFile TopLevelLet,
[], [],
("/root/Expression/DotLambda_TopLevelLet.fs", false,
QualifiedNameOfFile DotLambda_TopLevelLet, [], [],
[SynModuleOrNamespace
([TopLevelLet], false, AnonModule,
([DotLambda_TopLevelLet], false, AnonModule,
[Let
(false,
[SynBinding
Expand Down
0 .../DotLambda/TopLevelStandaloneDotLambda.fs → .../DotLambda_TopLevelStandaloneDotLambda.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...Lambda/TopLevelStandaloneDotLambda.fs.bsl → ...Lambda_TopLevelStandaloneDotLambda.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/TopLevelStandaloneDotLambda.fs", false,
QualifiedNameOfFile TopLevelStandaloneDotLambda, [], [],
("/root/Expression/DotLambda_TopLevelStandaloneDotLambda.fs", false,
QualifiedNameOfFile DotLambda_TopLevelStandaloneDotLambda, [], [],
[SynModuleOrNamespace
([TopLevelStandaloneDotLambda], false, AnonModule,
([DotLambda_TopLevelStandaloneDotLambda], false, AnonModule,
[Expr
(App
(NonAtomic, false,
Expand Down
0 ...unctionNallWithSpaceAndUnitApplication.fs → ...unctionNallWithSpaceAndUnitApplication.fs
View file
Open in desktop
File renamed without changes.
8 changes: 4 additions & 4 deletions ...ionNallWithSpaceAndUnitApplication.fs.bsl → ...ionNallWithSpaceAndUnitApplication.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/UnderscoreToFunctionNallWithSpaceAndUnitApplication.fs",
("/root/Expression/DotLambda_UnderscoreToFunctionNallWithSpaceAndUnitApplication.fs",
false,
QualifiedNameOfFile UnderscoreToFunctionNallWithSpaceAndUnitApplication,
[], [],
QualifiedNameOfFile
DotLambda_UnderscoreToFunctionNallWithSpaceAndUnitApplication, [], [],
[SynModuleOrNamespace
([UnderscoreToFunctionNallWithSpaceAndUnitApplication], false,
([DotLambda_UnderscoreToFunctionNallWithSpaceAndUnitApplication], false,
AnonModule,
[Let
(false,
Expand Down
0 ...yntaxTree/DotLambda/UnderscoreToString.fs → ...xpression/DotLambda_UnderscoreToString.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...xTree/DotLambda/UnderscoreToString.fs.bsl → ...ssion/DotLambda_UnderscoreToString.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/UnderscoreToString.fs", false,
QualifiedNameOfFile UnderscoreToString, [], [],
("/root/Expression/DotLambda_UnderscoreToString.fs", false,
QualifiedNameOfFile DotLambda_UnderscoreToString, [], [],
[SynModuleOrNamespace
([UnderscoreToString], false, AnonModule,
([DotLambda_UnderscoreToString], false, AnonModule,
[Expr
(DotLambda
(App
Expand Down
0 ...ee/DotLambda/WithNonTupledFunctionCall.fs → ...on/DotLambda_WithNonTupledFunctionCall.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...otLambda/WithNonTupledFunctionCall.fs.bsl → ...otLambda_WithNonTupledFunctionCall.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/WithNonTupledFunctionCall.fs", false,
QualifiedNameOfFile WithNonTupledFunctionCall, [], [],
("/root/Expression/DotLambda_WithNonTupledFunctionCall.fs", false,
QualifiedNameOfFile DotLambda_WithNonTupledFunctionCall, [], [],
[SynModuleOrNamespace
([WithNonTupledFunctionCall], false, AnonModule,
([DotLambda_WithNonTupledFunctionCall], false, AnonModule,
[Let
(false,
[SynBinding
Expand Down
0 ...e/data/SyntaxTree/DotLambda/WithoutDot.fs → ...axTree/Expression/DotLambda_WithoutDot.fs
View file
Open in desktop
File renamed without changes.
6 changes: 3 additions & 3 deletions ...ta/SyntaxTree/DotLambda/WithoutDot.fs.bsl → ...ee/Expression/DotLambda_WithoutDot.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
ImplFile
(ParsedImplFileInput
("/root/DotLambda/WithoutDot.fs", false, QualifiedNameOfFile WithoutDot, [],
[],
("/root/Expression/DotLambda_WithoutDot.fs", false,
QualifiedNameOfFile DotLambda_WithoutDot, [], [],
[SynModuleOrNamespace
([WithoutDot], false, AnonModule,
([DotLambda_WithoutDot], false, AnonModule,
[Expr
(App
(Atomic, false, Ident _ToString, Const (Unit, (1,9--1,11)),
Expand Down
0 ...SyntaxTree/DotLambda/WithoutUnderscore.fs → ...Expression/DotLambda_WithoutUnderscore.fs
View file
Open in desktop
File renamed without changes.
11 changes: 11 additions & 0 deletions tests/service/data/SyntaxTree/Expression/DotLambda_WithoutUnderscore.fs.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
ImplFile
(ParsedImplFileInput
("/root/Expression/DotLambda_WithoutUnderscore.fs", false,
QualifiedNameOfFile DotLambda_WithoutUnderscore, [], [],
[SynModuleOrNamespace
([DotLambda_WithoutUnderscore], false, AnonModule, [], PreXmlDocEmpty,
[], None, (1,0--1,1), { LeadingKeyword = None })], (true, true),
{ ConditionalDirectives = []
CodeComments = [] }, set []))

(1,0)-(1,1) parse error Unexpected symbol '.' in implementation file