Skip to content

Fix for #83 (improve constraint error message) #16304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 22 commits into from
Dec 20, 2023
Merged

Fix for #83 (improve constraint error message) #16304

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
01dda9b
Fix for issue83 (improve constraint error message)
Martin521 Nov 19, 2023
f1d5577
Automated command ran: xlf
github-actions[bot] Nov 19, 2023
ba19c54
fixed formatting
Martin521 Nov 19, 2023
e668683
fixed regression
Martin521 Nov 19, 2023
8825860
extended test for self-referring constraints
Martin521 Nov 19, 2023
1a4c3a5
fix for sign tests
Martin521 Nov 20, 2023
e462a17
adjusted fsharpqa test
Martin521 Nov 20, 2023
eaefa0c
fix looks good to me; all local tests passing
Martin521 Dec 10, 2023
eaf2c6f
internal merge
Martin521 Dec 10, 2023
05107ab
changed message text, added correct operator name
Martin521 Dec 11, 2023
2ae2462
Merge branch 'main' into issue83fix
Martin521 Dec 11, 2023
e3f46dc
change message text, fix logic, add correct operator name
Martin521 Dec 11, 2023
fcb0146
formatting fixed; improved error message
Martin521 Dec 11, 2023
51b3f23
fixed regression on enum test case
Martin521 Dec 11, 2023
91b5c7e
fixed expected error message in SignTests.fs
Martin521 Dec 11, 2023
3bd121f
fixed changed expected message in E_NoMethodsOnEnums01
Martin521 Dec 11, 2023
0532bb0
Removed the last line of E_NoMethodsOnEnums01
Martin521 Dec 11, 2023
b55ec10
another detail needed to change in an expected result in a test
Martin521 Dec 11, 2023
56419ab
Merge branch 'main' into issue83fix
Martin521 Dec 11, 2023
ae427e3
adding another test
Martin521 Dec 11, 2023
5fd3100
Merge branch 'main' into issue83fix
Martin521 Dec 18, 2023
54265bc
Merge branch 'main' into issue83fix
Martin521 Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed expected error message in SignTests.fs
  • Loading branch information
@Martin521
Martin521 committed Dec 11, 2023
commit 91b5c7ee18bf64ccc36c227f8cd8799cec1844af
8 changes: 4 additions & 4 deletions tests/fsharp/Compiler/Libraries/Core/Operators/SignTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ sign 0uy |> ignore
FSharpDiagnosticSeverity.Error
1
(2, 6, 2, 9)
"The type 'byte' does not support the operator 'get_Sign'"
"The type 'byte' does not support the operator 'sign'"

[<Test>]
let ``Sign of uint16``() =
Expand All @@ -56,7 +56,7 @@ sign 0us |> ignore
FSharpDiagnosticSeverity.Error
1
(2, 6, 2, 9)
"The type 'uint16' does not support the operator 'get_Sign'"
"The type 'uint16' does not support the operator 'sign'"

[<Test>]
let ``Sign of uint32``() =
Expand All @@ -67,7 +67,7 @@ sign 0u |> ignore
FSharpDiagnosticSeverity.Error
1
(2, 6, 2, 8)
"The type 'uint32' does not support the operator 'get_Sign'"
"The type 'uint32' does not support the operator 'sign'"

[<Test>]
let ``Sign of uint64``() =
Expand All @@ -78,4 +78,4 @@ sign 0uL |> ignore
FSharpDiagnosticSeverity.Error
1
(2, 6, 2, 9)
"The type 'uint64' does not support the operator 'get_Sign'"
"The type 'uint64' does not support the operator 'sign'"