Skip to content

Conversation

@brianrourkeboll
Copy link
Contributor

@brianrourkeboll brianrourkeboll commented Dec 5, 2023

Another followup to #16079.

Description

Keep parentheses around non-struct tuple patterns nested inside of & patterns, e.g.:

match x, y with
| (A, B) & (C, D) ->

Checklist

  • Test cases added.
  • Release notes entry updated.

As an aside: the AST-equivalence-asserting code that I originally hoped to include in #16079 does catch this, but it's still too messy and slow to include as part of the tests proper.

@brianrourkeboll brianrourkeboll marked this pull request as ready for review December 5, 2023 19:32
@brianrourkeboll brianrourkeboll requested a review from a team as a code owner December 5, 2023 19:32
@psfinaki psfinaki enabled auto-merge (squash) December 6, 2023 12:19
@psfinaki psfinaki merged commit 257702e into dotnet:main Dec 7, 2023
@brianrourkeboll brianrourkeboll deleted the parens-tuple-in-ands branch December 7, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants