Skip to content

Checker: recover on unresolved type in 'inherit' member #16429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abonie merged 2 commits into from
Dec 14, 2023
Merged

Checker: recover on unresolved type in 'inherit' member #16429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e157235
Checker: recover when checking 'inherit' members
auduchinok Dec 13, 2023
8ffbd2e
Add test
auduchinok Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Compiler/Checking/CheckDeclarations.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,10 +1334,10 @@ module MutRecBindingChecking =

// Phase2B: typecheck the argument to an 'inherits' call and build the new object expr for the inherit-call
| Phase2AInherit (synBaseTy, arg, baseValOpt, m) ->
let baseTy, tpenv = TcType cenv NoNewTypars CheckCxs ItemOccurence.Use WarnOnIWSAM.Yes envInstance tpenv synBaseTy
let baseTy = baseTy |> convertToTypeWithMetadataIfPossible g
let inheritsExpr, tpenv =
try
try
let baseTy, tpenv = TcType cenv NoNewTypars CheckCxs ItemOccurence.Use WarnOnIWSAM.Yes envInstance tpenv synBaseTy
let baseTy = baseTy |> convertToTypeWithMetadataIfPossible g
TcNewExpr cenv envInstance tpenv baseTy (Some synBaseTy.Range) true arg m
with RecoverableException e ->
errorRecovery e m
Expand Down
11 changes: 11 additions & 0 deletions tests/service/Symbols.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1123,3 +1123,14 @@ let z = builder
if symbolUse.Symbol.DisplayName = "builder" then
(symbolUse.Range.StartLine, symbolUse.Range.StartColumn), symbolUse.IsFromComputationExpression
]

module Member =
[<Test>]
let ``Inherit 01`` () =
let _, checkResults = getParseAndCheckResults """
type T() =
inherit Foo()

let i = 1
"""
assertHasSymbolUsages ["i"] checkResults