Skip to content

Revert 16348 #16536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vzarytovskii merged 18 commits into from
Jan 22, 2024
Merged

Revert 16348 #16536

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c3a6b0f
Improve AsyncMemoize tests
0101 Jan 16, 2024
de170ae
relax test condition
0101 Jan 16, 2024
af8fc6a
Revert "Cancellable: set token from node/async in features code (#163…
0101 Jan 16, 2024
0a9f728
remove UsingToken
0101 Jan 16, 2024
a03215e
remove UsingToken
0101 Jan 16, 2024
2ad0e81
test improvement
0101 Jan 16, 2024
c052c3f
Merge branch 'main' into revert-16348
0101 Jan 17, 2024
4a12103
relax test condition
0101 Jan 17, 2024
c511763
Merge branch 'revert-16348' of github.com:0101/fsharp into revert-16348
0101 Jan 17, 2024
22cc080
use thread-safe collections when collecting events from AsyncMemoize
0101 Jan 17, 2024
058d256
Merge branch 'main' into revert-16348
0101 Jan 17, 2024
480fc04
Merge branch 'main' into revert-16348
0101 Jan 18, 2024
94570d2
fix flaky test
0101 Jan 18, 2024
3511e23
Merge branch 'revert-16348' of https://github.com/0101/fsharp into re…
0101 Jan 18, 2024
a6ac788
release note
0101 Jan 18, 2024
049c809
Merge branch 'main' into revert-16348
0101 Jan 18, 2024
6671848
Merge branch 'main' into revert-16348
0101 Jan 19, 2024
dc5be02
Merge branch 'main' into revert-16348
0101 Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
relax test condition
  • Loading branch information
@0101
0101 committed Jan 16, 2024
commit de170ae939f7fe6ccdd82708926237dd93562a13
2 changes: 0 additions & 2 deletions tests/FSharp.Compiler.ComponentTests/CompilerService/AsyncMemoize.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,8 +249,6 @@ let ``Job is restarted if first requestor cancels but keeps running if second re
let! result = _task3
Assert.Equal(2, result)

Assert.Equal(TaskStatus.Canceled, _task1.Status)

let orderedLog = eventLog |> Seq.sortBy fst |> Seq.map snd |> Seq.toList
let expected = [ Started, key; Started, key; Finished, key ]

Expand Down