Skip to content

AsyncMemoize: do not cancel and restart jobs that are being requested #16547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
majocha wants to merge 52 commits into from
Closed

AsyncMemoize: do not cancel and restart jobs that are being requested #16547

Changes from 1 commit
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
c3a6b0f
Improve AsyncMemoize tests
0101 Jan 16, 2024
de170ae
relax test condition
0101 Jan 16, 2024
af8fc6a
Revert "Cancellable: set token from node/async in features code (#163…
0101 Jan 16, 2024
0a9f728
remove UsingToken
0101 Jan 16, 2024
a03215e
remove UsingToken
0101 Jan 16, 2024
2ad0e81
test improvement
0101 Jan 16, 2024
5bdae17
test improvement
0101 Jan 16, 2024
c052c3f
Merge branch 'main' into revert-16348
0101 Jan 17, 2024
569b50a
Merge branch 'main' into improve-async-tests
0101 Jan 17, 2024
76223ff
Merge remote-tracking branch '0101/revert-16348' into asyncmemo
majocha Jan 17, 2024
f3f4559
Task.Yield
majocha Jan 17, 2024
4a12103
relax test condition
0101 Jan 17, 2024
c511763
Merge branch 'revert-16348' of github.com:0101/fsharp into revert-16348
0101 Jan 17, 2024
8ee674c
relax test condition
0101 Jan 17, 2024
c1fb312
unindent a bit
majocha Jan 17, 2024
77920a6
Merge remote-tracking branch '0101/revert-16348' into asyncmemo
majocha Jan 17, 2024
1a66d72
fantomas
majocha Jan 17, 2024
a8201eb
draft release notes
majocha Jan 17, 2024
8d00ee6
use thread-safe collections when collecting events from AsyncMemoize
0101 Jan 17, 2024
22cc080
use thread-safe collections when collecting events from AsyncMemoize
0101 Jan 17, 2024
da52d7c
try adding Cancellable.UsingToken in ProjectWorkflowBuilder
0101 Jan 17, 2024
058d256
Merge branch 'main' into revert-16348
0101 Jan 17, 2024
e0a81c6
this might be better
0101 Jan 17, 2024
de74123
sprinkle in some more Cancellable.UsingToken
0101 Jan 17, 2024
27b492a
revert
0101 Jan 17, 2024
ff13476
f
0101 Jan 17, 2024
adeeb88
Merge remote-tracking branch '0101/revert-16348' into asyncmemo
majocha Jan 17, 2024
a82f875
Merge branch 'main' into improve-async-tests
0101 Jan 17, 2024
6617652
Merge branch 'asyncmemo' of https://github.com/majocha/fsharp into as…
majocha Jan 17, 2024
78048ce
only posted cancel requests
majocha Jan 17, 2024
1cc0ffd
format
majocha Jan 17, 2024
4319d1d
don't restart while there are requestors
majocha Jan 18, 2024
9090f3f
add test
majocha Jan 18, 2024
36ed2ab
no restart
majocha Jan 18, 2024
607d1e1
wip rel notes
majocha Jan 18, 2024
6a06ad1
merge from improve-async.tests
majocha Jan 18, 2024
98e6271
Merge branch 'main' into asyncmemo-no-restart
majocha Jan 18, 2024
6132eae
try to fix test
majocha Jan 18, 2024
337ba5d
Merge branch 'asyncmemo-no-restart' of https://github.com/majocha/fsh…
majocha Jan 18, 2024
cb660ce
rel notes
majocha Jan 18, 2024
e23f203
fix flaky test
majocha Jan 18, 2024
e4e5b59
fix test again
majocha Jan 18, 2024
a6930de
Merge branch 'main' into asyncmemo-no-restart
0101 Jan 18, 2024
b152e6d
stringbuilder is not threadsafe
majocha Jan 19, 2024
2e0fa2f
merge test fix
majocha Jan 20, 2024
0001d0e
Merge branch 'main' into asyncmemo-no-restart
majocha Jan 20, 2024
c623ea8
try to fix test
majocha Jan 20, 2024
73643fd
just in case
majocha Jan 20, 2024
9fef34b
revert
majocha Jan 22, 2024
41a849c
tests
majocha Jan 22, 2024
298b8f0
Merge branch 'main' into asyncmemo-no-restart
majocha Jan 22, 2024
010a418
try fix test
majocha Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
f
  • Loading branch information
@0101
0101 committed Jan 17, 2024
commit ff134767ab6f03914e52afb3d609fe57a254b98d
1 change: 1 addition & 0 deletions src/Compiler/Service/TransparentCompiler.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,6 +1790,7 @@ type internal TransparentCompiler

member _.FindReferencesInFile(fileName: string, projectSnapshot: ProjectSnapshot, symbol: FSharpSymbol, userOpName: string) =
ignore userOpName

node {
let! ct = NodeCode.CancellationToken
use _ = Cancellable.UsingToken(ct)
Expand Down