Skip to content

Feature nullness :: warn also for 'obj' type (since it can be infered for null literal) #16962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 24 commits into from
Apr 19, 2024
Merged

Feature nullness :: warn also for 'obj' type (since it can be infered for null literal) #16962

Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
4ba648b
mkAppTy resolved
T-Gro Mar 14, 2024
1429960
mkFunTyWithNullness
T-Gro Mar 14, 2024
664416c
adding failing tests for fsharp types
T-Gro Mar 18, 2024
c812e13
Merge remote-tracking branch 'upstream/main' into feature-nullness-re…
T-Gro Mar 19, 2024
5247050
delayed checks of post-infered values for nullness-carrying capabilities
T-Gro Mar 20, 2024
a4b60a2
Merge branch 'feature/nullness' into feature-nullness-resolveTODOs
T-Gro Mar 20, 2024
e4c0bfd
more tests
T-Gro Mar 20, 2024
41cc2b7
Merge branch 'feature-nullness-resolveTODOs' of https://github.com/T-…
T-Gro Mar 20, 2024
ed01053
Merge branch 'feature/nullness' into feature-nullness-resolveTODOs
T-Gro Mar 21, 2024
07f190f
Merge branch 'feature/nullness' into feature-nullness-resolveTODOs
T-Gro Mar 22, 2024
4827b98
fix xliffs
T-Gro Mar 22, 2024
1a9d715
Merge branch 'feature/nullness' into feature-nullness-resolveTODOs
T-Gro Mar 25, 2024
cc102b4
Regression on passing null literal - to be fixed
T-Gro Mar 25, 2024
bd62198
regression with obj - captured as a test
T-Gro Mar 26, 2024
f0b4c38
autowiden tests change from preview to 8
T-Gro Mar 26, 2024
bc974da
invetigate CI test failures
T-Gro Mar 26, 2024
0a5b298
warnon 3262
T-Gro Mar 26, 2024
1e2e96b
Merge branch 'feature/nullness' into feature-nullness-resolveTODOs
T-Gro Mar 26, 2024
a22b560
null handling for obj type
T-Gro Mar 28, 2024
9e77b54
fantomas
T-Gro Mar 28, 2024
a7a72b2
Merge branch 'feature/nullness' into feature-nullness-objty
T-Gro Mar 28, 2024
877ee59
anon records nullness
T-Gro Apr 2, 2024
118346c
Merge remote-tracking branch 'upstream/main' into feature-nullness-objty
T-Gro Apr 3, 2024
f47bcce
Merge branch 'feature/nullness' into feature-nullness-objty
T-Gro Apr 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
anon records nullness
  • Loading branch information
@T-Gro
T-Gro committed Apr 2, 2024
commit 877ee59b32cf6a93eaf6813c79da8e4393e61ed3
8 changes: 8 additions & 0 deletions tests/FSharp.Compiler.ComponentTests/EmittedIL/Nullness/AnonRecords.fs.il.netcore.bsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,8 @@
.method public hidebysig virtual final instance int32 CompareTo(object obj) cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.param [1]
.custom instance void [runtime]System.Runtime.CompilerServices.NullableAttribute::.ctor(uint8) = ( 01 00 02 00 00 )

.maxstack 8
IL_0000: ldarg.0
Expand All @@ -352,6 +354,8 @@
class [runtime]System.Collections.IComparer comp) cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.param [1]
.custom instance void [runtime]System.Runtime.CompilerServices.NullableAttribute::.ctor(uint8) = ( 01 00 02 00 00 )

.maxstack 5
.locals init (class '<>f__AnonymousType2430756162`3'<!'<A>j__TPar',!'<B>j__TPar',!'<C>j__TPar'> V_0,
Expand Down Expand Up @@ -524,6 +528,8 @@
class [runtime]System.Collections.IEqualityComparer comp) cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.param [1]
.custom instance void [runtime]System.Runtime.CompilerServices.NullableAttribute::.ctor(uint8) = ( 01 00 02 00 00 )

.maxstack 5
.locals init (class '<>f__AnonymousType2430756162`3'<!'<A>j__TPar',!'<B>j__TPar',!'<C>j__TPar'> V_0,
Expand Down Expand Up @@ -643,6 +649,8 @@
.method public hidebysig virtual final instance bool Equals(object obj) cil managed
{
.custom instance void [runtime]System.Runtime.CompilerServices.CompilerGeneratedAttribute::.ctor() = ( 01 00 00 00 )
.param [1]
.custom instance void [runtime]System.Runtime.CompilerServices.NullableAttribute::.ctor(uint8) = ( 01 00 02 00 00 )

.maxstack 4
.locals init (class '<>f__AnonymousType2430756162`3'<!'<A>j__TPar',!'<B>j__TPar',!'<C>j__TPar'> V_0)
Expand Down