Skip to content

Parens: some more #17012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psfinaki merged 12 commits into from
Apr 10, 2024
Merged

Parens: some more #17012

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
41ac0c4
Keep parens for prefix & infix apps in copy exprs
brianrourkeboll Apr 3, 2024
e1b420f
Better handling of nested arrow-sensitive constructs
brianrourkeboll Apr 3, 2024
6b439d3
Can't have bare typed exprs in records
brianrourkeboll Apr 3, 2024
f3bd16d
Keep parens around unit in func/method invocation
brianrourkeboll Apr 3, 2024
8e66a30
Handle app chains depending on pseudo-dot prec
brianrourkeboll Apr 6, 2024
a12888d
Add space around underscores
brianrourkeboll Apr 8, 2024
019f82f
Merge branch 'main' of https://github.com/dotnet/fsharp into parens-s…
brianrourkeboll Apr 8, 2024
005cc16
Keep parens around hanging tuples
brianrourkeboll Apr 8, 2024
d31886c
Handle some simple cases of #16999
brianrourkeboll Apr 9, 2024
aedad98
Merge branch 'main' of https://github.com/dotnet/fsharp into parens-s…
brianrourkeboll Apr 9, 2024
6b706c3
Update release notes
brianrourkeboll Apr 9, 2024
8b3f689
Update release notes
brianrourkeboll Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Can't have bare typed exprs in records
  • Loading branch information
@brianrourkeboll
brianrourkeboll committed Apr 3, 2024
commit 6b439d3ffe6bc13fffc4607de89e889744215d16
2 changes: 0 additions & 2 deletions src/Compiler/Service/SynExpr.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,8 +1013,6 @@ module SynExpr =

| SynExpr.Paren _, SynExpr.Typed _
| SynExpr.Quote _, SynExpr.Typed _
| SynExpr.AnonRecd _, SynExpr.Typed _
| SynExpr.Record _, SynExpr.Typed _
| SynExpr.While(doExpr = SynExpr.Paren(expr = Is inner)), SynExpr.Typed _
| SynExpr.WhileBang(doExpr = SynExpr.Paren(expr = Is inner)), SynExpr.Typed _
| SynExpr.For(doBody = Is inner), SynExpr.Typed _
Expand Down
22 changes: 22 additions & 0 deletions vsintegration/tests/FSharp.Editor.Tests/CodeFixes/RemoveUnnecessaryParenthesesTests.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1427,6 +1427,17 @@ in x
A = 4 |}
"

"
{|
A = ([] : int list list)
|}
",
"
{|
A = ([] : int list list)
|}
"

// ArrayOrList
"id ([])", "id []"
"id ([||])", "id [||]"
Expand Down Expand Up @@ -1484,6 +1495,17 @@ in x
A = 4 }
"

"
{
A = ([] : int list list)
}
",
"
{
A = ([] : int list list)
}
"

// New
"id (new obj())", "id (new obj())"

Expand Down