Fix full source-build product build when running R2R #17259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ No release notes required |
vzarytovskii
approved these changes
May 28, 2024
tmds
reviewed
May 28, 2024
See dotnet/source-build#4410 When building from source, we must set the RuntimeIdentifier property explicitly as otherwise the SDK defaults to the portable RID. Also make the SDK aware of the R2R build by updating the Known* items in Directory.Build.targets and remove the AspNetCore framework references.
ViktorHofer
force-pushed
the
FixSourceBuildWhenRunningR2Run
branch
4 times, most recently
from
9b7512c to
b793e15
Compare
ViktorHofer
force-pushed
the
FixSourceBuildWhenRunningR2Run
branch
from
b793e15 to
7271b27
Compare
KevinRansom
approved these changes
May 28, 2024
vzarytovskii
approved these changes
May 29, 2024
Member
|
Should auto-merge once approved by someone from SB-internal team and all comments are resolved. |
Member
|
Oh, for some reason it wasn't blocked by the comment. @ViktorHofer is it ok that it got merged, or does it need some more changes? We can hold on with merging to release branch and wait for fixes (if any). |
|
viktor used the same patch in sdk, everything was fine dotnet/sdk@43ff4fd. need to remove the patch once fsharp update pops up via codeflow in sdk. |
Member
Author
|
exactly |
This was referenced Jun 7, 2024
vzarytovskii
added a commit
that referenced
this pull request
Jun 21, 2024
Co-authored-by: Kevin Ransom (msft) <[email protected]> Co-authored-by: Petr <[email protected]> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Brian Rourke Boll <[email protected]> Co-authored-by: Vlad Zarytovskii <[email protected]> Co-authored-by: Viktor Hofer <[email protected]> Co-authored-by: Florian Verdonck <[email protected]> Co-authored-by: Jakub Majocha <[email protected]> Co-authored-by: ijklam <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dawe <[email protected]> Co-authored-by: Tom Deseyn <[email protected]> Fix AOT (#17238)" (#17264) Fix full source-build product build when running R2R (#17259) Fix plain build of FSC fsproj (#17270) Fix #14375 by showing and inserting correct name of entities from unopened namespace/module (#17261) fix #14375 Fix a typo in docs (#17273) Fix sbom generation (#17275)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dotnet/source-build#4410 When building from source, we must set the
RuntimeIdentifier property explicitly as otherwise the SDK defaults to the portable RID.
Also make the SDK aware of the R2R build by updating the Known* items in Directory.Build.targets and
remove the AspNetCore framework references.