Feature nullness :: Subsume nullness for contravariant type parameters (such as the one in IEqualityComparer<in T>) #17398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature is driven by an occurence of BCL type design which I encountered during testing.
IEqualityComparer<in T>StringComparer.Ordinal :
IEqualityComparer<string | null>But constructors of all dictionary-like types needing an
IEqualityComparer<string>Which would not much.
At the same time, natural conversion from Type<T | null> to Type cannot be done out of the box, since we cannot control how the
Tis used internally.This nullness-equality relaxation can only be done for contravariant generic parameters (
<in T>), which is used for interfaces taking the generic typar in its input.