Skip to content

Support ldelem.u8, ldelem.u opcode aliases #18081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
T-Gro merged 7 commits into from
Dec 2, 2024
Merged

Support ldelem.u8, ldelem.u opcode aliases #18081

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1cd73db
Emit `ldelem.i8`, `ldelem.i`, etc.
brianrourkeboll Nov 27, 2024
969eb0a
Update release notes
brianrourkeboll Nov 27, 2024
b6a8658
Probably better
brianrourkeboll Nov 27, 2024
23eb581
Support `ldelem.u8`, `ldelem.u` opcode aliases
brianrourkeboll Nov 28, 2024
85057a5
Merge main
brianrourkeboll Nov 29, 2024
6a46cd1
Fix merge
brianrourkeboll Nov 29, 2024
1e121c2
Merge branch 'main' into uint64-ldelem
psfinaki Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Support ldelem.u8, ldelem.u opcode aliases
  • Loading branch information
@brianrourkeboll
brianrourkeboll committed Nov 28, 2024
commit 23eb581165845289986e6978edf7dce8f8504536
4 changes: 2 additions & 2 deletions src/Compiler/AbstractIL/ilwrite.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2026,11 +2026,11 @@ module Codebuf =
| I_ldelem dt ->
emitInstrCode codebuf
(match dt with
| DT_I -> i_ldelem_i
| DT_I | DT_U -> i_ldelem_i
| DT_I1 -> i_ldelem_i1
| DT_I2 -> i_ldelem_i2
| DT_I4 -> i_ldelem_i4
| DT_I8 -> i_ldelem_i8
| DT_I8 | DT_U8 -> i_ldelem_i8
| DT_U1 -> i_ldelem_u1
| DT_U2 -> i_ldelem_u2
| DT_U4 -> i_ldelem_u4
Expand Down
6 changes: 4 additions & 2 deletions src/Compiler/Optimize/LowerComputedCollections.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,9 +359,11 @@ module List =
module Array =
let private mkIlInstr (g: TcGlobals) specific any ilTy =
if ilTy = g.ilg.typ_Int32 then specific DT_I4
elif ilTy = g.ilg.typ_Int64 || ilTy = g.ilg.typ_UInt64 then specific DT_I8
elif ilTy = g.ilg.typ_Int64 then specific DT_I8
elif ilTy = g.ilg.typ_UInt64 then specific DT_U8
elif ilTy = g.ilg.typ_UInt32 then specific DT_U4
elif ilTy = g.ilg.typ_IntPtr || ilTy = g.ilg.typ_UIntPtr then specific DT_I
elif ilTy = g.ilg.typ_IntPtr then specific DT_I
elif ilTy = g.ilg.typ_UIntPtr then specific DT_U
elif ilTy = g.ilg.typ_Int16 then specific DT_I2
elif ilTy = g.ilg.typ_UInt16 then specific DT_U2
elif ilTy = g.ilg.typ_SByte then specific DT_I1
Expand Down