Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
5c1cb81
Initial plan
Copilot Sep 8, 2025
1713662
Add basic XML doc comment position warning - initial implementation
Copilot Sep 8, 2025
8698eef
Add warning for XML documentation comments not positioned as first no…
Copilot Sep 8, 2025
21333cf
Fix XML doc comment position check to analyze actual line content ins…
Copilot Sep 8, 2025
7d2be7e
Address feedback by disabling hardcoded column limit approach tempora…
Copilot Sep 8, 2025
6413c55
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
T-Gro Sep 18, 2025
92f2c02
Address feedback: remove hardcoded column limit, disable warning temp…
Copilot Sep 19, 2025
e12e8cc
Implement XML doc comment position check in LexFilter instead of lexe…
Copilot Sep 19, 2025
fb42cf8
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
T-Gro Sep 22, 2025
28a6204
Fix type constraint mismatch in FSComp.SR.xmlDocNotFirstOnLine() usage
Copilot Sep 22, 2025
56607de
Fix unused variable warning in LexFilter pattern match
Copilot Sep 22, 2025
9d9a664
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
T-Gro Oct 17, 2025
83a3454
Update xlf localization files for xmlDocNotFirstOnLine entry
Copilot Nov 30, 2025
bd22c0e
Add lexer-level tracking for XML doc comment position warning
Copilot Dec 2, 2025
3070e3d
Fix incorrect /// comment usage in infos.fs - should be //
Copilot Dec 2, 2025
1f45f17
Disable XML doc position warning - implementation too aggressive
Copilot Dec 3, 2025
4ac9a26
Re-implement XML doc comment position warning using token position tr…
Copilot Dec 3, 2025
a560672
Add token position tracking to more token types and start updating tests
Copilot Dec 3, 2025
3f936f2
Update XmlDocTests to expect FS3879 warning for misplaced /// comments
Copilot Dec 3, 2025
df81dfb
Fix remaining test failures: update neg45.bsl baseline and type membe…
Copilot Dec 3, 2025
fc51e55
Fix code formatting in LexHelpers.fs and LexHelpers.fsi
Copilot Dec 3, 2025
4b58239
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
abonie Dec 5, 2025
c24643d
Update neg45.bsl baseline with all three FS3879 warnings
Copilot Dec 5, 2025
c2736dc
Fix /// comment in Trimming/Program.fs that was causing build failures
Copilot Dec 5, 2025
e171853
Change triple slash to regular comments
abonie Dec 8, 2025
b4a85cb
Fix XML documentation comment parse errors
abonie Dec 8, 2025
b3984a0
Undo changes to neg45.bsl
abonie Dec 8, 2025
0c6e957
Suppress FS3879 warning in AOT trimming test projects
Copilot Dec 9, 2025
d4b6661
Add release notes entry for FS3879 warning
Copilot Dec 9, 2025
c2112c5
Add test for DU cases with /// after case definition
Copilot Dec 9, 2025
2faae14
Fix DU test - use correct lambda signature (fun _ -> ()) instead of (…
Copilot Dec 10, 2025
4d16c5b
Fix DU test expected column positions - CaseB line should be Col 12, …
Copilot Dec 10, 2025
1006511
Rewrite XML doc position warning using LexFilter approach
Copilot Dec 31, 2025
337178d
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
T-Gro Jan 2, 2026
250ed38
Move release notes entry to 10.0.200.md as requested
Copilot Jan 2, 2026
696e8fb
Fix compilation errors - use COMMENT token and fix ODECLEND tuple
Copilot Jan 2, 2026
94f182c
Fix LexFilter code to properly check for XML doc comments
Copilot Jan 5, 2026
b3af608
fix build errors
T-Gro Jan 5, 2026
6a8696e
Apply patch from /run fantomas
actions-user Jan 5, 2026
c73cc4e
Fix FS3879 warning - move check from LexFilter to lex.fsl
Copilot Jan 5, 2026
001cbda
Allow XML doc comments after opening brace and equals in record types
Copilot Jan 6, 2026
541d143
Create proper GitHub Copilot Skills per documentation
Copilot Jan 6, 2026
5a4f398
Enhance GitHub Copilot Skills per review feedback
Copilot Jan 6, 2026
2fec170
Change FS3879 to informational warning and enable in F# codebase
Copilot Jan 6, 2026
60dd7bb
Fix invalid XML doc comments in Intellisense.fs
Copilot Jan 6, 2026
f3164c7
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
T-Gro Jan 6, 2026
c144a34
Apply suggestions from code review
T-Gro Jan 6, 2026
c014a7a
Merge branch 'main' into copilot/fix-920e1d4e-0c13-4c25-8d7b-183dbc29…
T-Gro Jan 12, 2026
2a31793
Remove no-op match and add tests for XML doc after = and { in express…
Copilot Jan 12, 2026
cca22f3
Update tests/FSharp.Compiler.Service.Tests/XmlDocTests.fs
T-Gro Jan 13, 2026
9fa902a
Update tests/FSharp.Compiler.Service.Tests/XmlDocTests.fs
T-Gro Jan 13, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update neg45.bsl baseline with all three FS3879 warnings
Added missing warnings for lines 97 and 102 where /// EXPECT ERROR
comments appear after code on the same line.

Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
  • Loading branch information
Copilot and abonie committed Dec 5, 2025
commit c24643d3c28cf8114b790a695b36805cd4eee2ce
4 changes: 4 additions & 0 deletions tests/fsharp/typecheck/sigs/neg45.bsl
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
neg45.fs(89,42,89,45): parse error FS3879: XML documentation comments should be the first non-whitespace text on a line.

neg45.fs(97,55,97,58): parse error FS3879: XML documentation comments should be the first non-whitespace text on a line.

neg45.fs(102,30,102,33): parse error FS3879: XML documentation comments should be the first non-whitespace text on a line.

neg45.fs(12,5,12,11): typecheck error FS0685: The generic function 'Foo' must be given explicit type argument(s)

neg45.fs(14,5,14,11): typecheck error FS0685: The generic function 'Foo' must be given explicit type argument(s)
Expand Down
Loading