Skip to content

Generate source for .resx files on build. #3607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettfo merged 16 commits into from
Sep 22, 2017
Merged

Generate source for .resx files on build. #3607

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
01c4674
add build task to generate *.fs from *.resx files
brettfo Sep 15, 2017
67295f7
generate source for embedded resources in tests
brettfo Sep 18, 2017
0727149
generate source for embedded resources in FSharp.Editor
brettfo Sep 18, 2017
1ce305b
generate source for embedded resources in FSharp.LanguageService
brettfo Sep 18, 2017
e26198f
generate source for embedded resources in FSharp.ProjectSystem.FSharp
brettfo Sep 18, 2017
9105693
generate source for embedded resources in FSharp.VS.FSI
brettfo Sep 19, 2017
289dd15
don't generate non-string resources when <=netstandard1.6
brettfo Sep 19, 2017
c1ab08a
update baseline error message for tests
brettfo Sep 20, 2017
decdcb0
perform up-to-date check before generating *.fs from *.resx
brettfo Sep 20, 2017
71c0931
remove non-idiomatic fold for an array comprehension
brettfo Sep 20, 2017
1245d59
correct newline replacement
brettfo Sep 20, 2017
7209630
output more friendly error message
brettfo Sep 20, 2017
4f321fd
throw if boolean value isn't explicitly `true` or `false`
brettfo Sep 20, 2017
c89546f
only generate object resource code on non `netstandard1.*` and `netco…
brettfo Sep 20, 2017
7594f7f
ensure FSharp.Core specifies a target framework for resource generaton
brettfo Sep 20, 2017
18ea1fa
rename attributes to be non-ambiguous and properly include them
brettfo Sep 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
throw if boolean value isn't explicitly true or false
  • Loading branch information
@brettfo
brettfo committed Sep 20, 2017
commit 4f321fdd31976d7db8a0179efa5e5dde7232c483
6 changes: 5 additions & 1 deletion src/fsharp/FSharp.Build/FSharpEmbedResXSource.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,11 @@ module internal {1} =
let getBooleanMetadata (metadataName:string) (defaultValue:bool) (item:ITaskItem) =
match item.GetMetadata(metadataName) with
| value when String.IsNullOrWhiteSpace(value) -> defaultValue
| value -> String.Compare(value, "true", StringComparison.OrdinalIgnoreCase) = 0
| value ->
match value.ToLowerInvariant() with
| "true" -> true
| "false" -> false
| _ -> failwith (sprintf "Expected boolean value for '%s' found '%s'" metadataName value)
let mutable success = true
let generatedSource =
[| for item in this.EmbeddedResource do
Expand Down