forward warnings when searching for a method overload #4481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsyme
reviewed
Mar 12, 2018
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
This looks good and I'm glad to see you found the cause of the issue.
Just one main comment - any reason you're not using a negNN.fs test?
tests/fsharp/tests.fs
Outdated
|
|
||
| [<Test>] | ||
| let ``typeinferenceWarning`` () = | ||
| let cfg = testConfig "core/typeinferenceWarning" |
Contributor
There was a problem hiding this comment.
Normally we'd add a negNN.fs test for such a case? Is there any reason not to be doing that?
Contributor
Author
There was a problem hiding this comment.
Reason is that I have no idea what I’m doing but I still wanted to add a test ;)
Is there docs around that or can someone help?
Contributor
There was a problem hiding this comment.
typecheck/sigs/neg101.fs etc. for example
Contributor
Author
|
@dsyme Thanks, this makes the test-code a bit simpler :) |
Contributor
Author
|
@dsyme Ok I think this is ready. |
dsyme
approved these changes
Mar 15, 2018
KevinRansom
approved these changes
Mar 17, 2018
Contributor
|
@matthid Thanks for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3752