Warn on use of inbox TP #5060
Merged
Warn on use of inbox TP #5060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
MSBuild voodoo is extraordinary to behold :) |
dsyme
approved these changes
Jun 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a warning message to the build if we discover the use of an inbox type provider. Eventually we may stop deploying this .Dll. The warning is in the build targets and benign.
The message:
Text="This Project references the obsolete in-box TypeProvider: FSharp.Data.TypeProviders.dll. Consider Switching to the Nuget package version: https://www.nuget.org/packages/FSharp.Data.TypeProviders."
@dsyme
There is a bit of an issue with this, because the nuget package has obsoleted use of the Microsoft.FSharp namespace. I will be proposing a PR that removes that obsoletion. We would prefer that developers can switch to the nuget version without having to modify source code.