UIThread #5128
Merged
UIThread #5128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
If this means one step closer to the vs integration tests being enabled again, this is good 🙂 |
Contributor
Author
|
@smoothdeveloper I wish I had never noticed they were broken. |
Contributor
|
that doesn't solve the issue that @vasily-kirichenko would have found out 😄 Is there opportunity at later stage to just have one class or they are meant to differ for some reasons in the future? Not taking the dependency feels clean but not if we had to duplicate large class in both projects. |
Contributor
Author
|
@smoothdeveloper Don moved files about, so the history only goes back to 2016. So I have no idea why there are two of them. However, the ProjectSystem.dll is legacy, and will hopefully go away eventually. |
dsyme
approved these changes
Jun 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst trying to get the tests passing I needed to initialize the UIThread helper class for testing.
It turns out we have two, one for LanguageService base, and One for ProjectSystem.Base. It looks like there was a copy and paste job, because both were in the Blah.LanguageService namespace. I renamed the one in the ProjectSystem library to be in the Blah.ProjectSystem namespace.
Further it turns out that only one of the two helpers were ever initialized on package load, so I now initialize both.
I guess the notion for two seperate assemblies, was to not have the ProjectSystem.base take a dependency on the LanguageService.Base assembly. I guess for this one type that was probably an okay call.
Kevin