Fix ParseAndCheckDocument #5175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@KevinRansom / @brettfo / @TIHan we should take this for 15.8 |
Contributor
Author
|
Please test it on large files having this setting set to various values
|
vasily-kirichenko
changed the title
KevinRansom
approved these changes
Jun 18, 2018
dsyme
reviewed
Jun 19, 2018
| return Some (parseResults, checkFileResults) | ||
| | _ -> | ||
| return! worker | ||
| return! parseAndCheckFile |
Contributor
There was a problem hiding this comment.
Please make parseAndCheckFile a function parseAndCheckFile () to make things more obvious
dsyme
approved these changes
Jun 19, 2018
Contributor
dsyme
left a comment
dsyme
left a comment
There was a problem hiding this comment.
Just one change requested but it's only to clarify the code
cartermp
approved these changes
Jun 20, 2018
Contributor
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Played around with TypeChecker.fs with various values and can't get it to reproduce.
Contributor
|
Link #5172 |
KevinRansom
pushed a commit
to KevinRansom/fsharp
that referenced
this pull request
Jun 20, 2018
KevinRansom
pushed a commit
that referenced
this pull request
Jun 21, 2018
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
nosami
pushed a commit
to xamarin/visualfsharp
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5173