Add support for --pathmap #5801
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge from upstream
Contributor
Author
|
cc @brettfo |
TD5
reviewed
Oct 20, 2018
| type PathMap = PathMap of Map<string, string> | ||
|
|
||
| [<RequireQualifiedAccess>] | ||
| module internal PathMap = |
Contributor
Author
There was a problem hiding this comment.
Thanks Tom - ideally we'd have a properly typed filesystem (so that this wasn't string -> string), but alas
cartermp
reviewed
Nov 13, 2018
| @@ -1,3 +1,3 @@ | |||
| // #NoMT #CompilerOptions #Determinism | |||
| //<Expects id="FS2026" status="error">Determinstic builds only support portable PDBs</Expects> | |||
| //<Expects id="FS2026" status="error">Deterministic builds only support portable PDBs</Expects> | |||
Contributor
|
@brettfo @KevinRansom @dsyme can y'all take a look? |
brettfo
approved these changes
Apr 22, 2019
Contributor
Author
|
Before merging, I’ll pull this up to master and add support for |
Contributor
Author
|
Superseded by #6609, closing this off. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseded by #6609
Fixes #5213, #3812